Do not install WebAPKs with web manifests with invalid URL components

chrome/browser/installable/installable_logging.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/installable/installable_logging.h"
 
 #include "base/macros.h"
 #include "base/strings/stringprintf.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 41 matching lines @@
     "could not download the specified icon";
 static const char kNoIconAvailableMessage[] =
     "no icon available to display";
 static const char kPlatformNotSupportedOnAndroidMessage[] =
     "the specified application platform is not supported on Android";
 static const char kNoIdSpecifiedMessage[] =
     "no Play store ID provided";
 static const char kIdsDoNotMatchMessage[] =
     "a Play Store app URL and Play Store ID were specified in the manifest, "
     "but they do not match";
+static const char kUrlNotSupportedForWebApkMessage[] =

[dominickn, 2016/08/29 00:15:41]

Nit: you removed checking the username for a port, but the error message still
mentions a port!

+    "a URL in the web manifest contains a username, password, or port";
 
 }  // namespace
 
 void LogErrorToConsole(content::WebContents* web_contents,
                        InstallableStatusCode code,
                        const std::string& param) {
   if (!web_contents)
     return;
 
   content::ConsoleMessageLevel severity = content::CONSOLE_MESSAGE_LEVEL_ERROR;
@@ skipping 61 matching lines @@
     case PLATFORM_NOT_SUPPORTED_ON_ANDROID:
       pattern = kPlatformNotSupportedOnAndroidMessage;
       severity = content::CONSOLE_MESSAGE_LEVEL_WARNING;
       break;
     case NO_ID_SPECIFIED:
       pattern = kNoIdSpecifiedMessage;
       break;
     case IDS_DO_NOT_MATCH:
       pattern = kIdsDoNotMatchMessage;
       break;
+    case URL_NOT_SUPPORTED_FOR_WEBAPK:
+      pattern = kUrlNotSupportedForWebApkMessage;
+      break;
   }
 
   if (!pattern)
     return;
   std::string message = param.empty() ?
       pattern : base::StringPrintf(pattern, param.c_str());
   web_contents->GetMainFrame()->AddMessageToConsole(
       severity, GetMessagePrefix() + message);
 }