Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4008)

Unified Diff: chrome/browser/installable/installable_manager.h

Issue 2248293002: Do not install WebAPKs with web manifests with invalid URL components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/installable/installable_manager.h
diff --git a/chrome/browser/installable/installable_manager.h b/chrome/browser/installable/installable_manager.h
index 92ac41eb5d66afa7e45beab6257fd72bae7dc22a..3c2f1279794d95b7a4bc23a390b9a98f67071070 100644
--- a/chrome/browser/installable/installable_manager.h
+++ b/chrome/browser/installable/installable_manager.h
@@ -158,7 +158,8 @@ class InstallableManager
const content::Manifest& manifest);
void CheckInstallable();
- bool IsManifestValidForWebApp(const content::Manifest& manifest);
+ bool IsManifestValidForWebApp(const GURL& manifest_url,
+ const content::Manifest& manifest);
void CheckServiceWorker();
void OnDidCheckHasServiceWorker(bool has_service_worker);

Powered by Google App Engine
This is Rietveld 408576698