Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: chrome/browser/installable/installable_manager.h

Issue 2248293002: Do not install WebAPKs with web manifests with invalid URL components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_ 5 #ifndef CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_
6 #define CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_ 6 #define CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 void RunCallback(const Task& task, InstallableStatusCode error); 151 void RunCallback(const Task& task, InstallableStatusCode error);
152 void StartNextTask(); 152 void StartNextTask();
153 void WorkOnTask(); 153 void WorkOnTask();
154 154
155 // Data retrieval methods. 155 // Data retrieval methods.
156 void FetchManifest(); 156 void FetchManifest();
157 void OnDidGetManifest(const GURL& manifest_url, 157 void OnDidGetManifest(const GURL& manifest_url,
158 const content::Manifest& manifest); 158 const content::Manifest& manifest);
159 159
160 void CheckInstallable(); 160 void CheckInstallable();
161 bool IsManifestValidForWebApp(const content::Manifest& manifest); 161 bool IsManifestValidForWebApp(const GURL& manifest_url,
162 const content::Manifest& manifest);
162 void CheckServiceWorker(); 163 void CheckServiceWorker();
163 void OnDidCheckHasServiceWorker(bool has_service_worker); 164 void OnDidCheckHasServiceWorker(bool has_service_worker);
164 165
165 void CheckAndFetchBestIcon(); 166 void CheckAndFetchBestIcon();
166 void OnAppIconFetched(const GURL icon_url, const SkBitmap& bitmap); 167 void OnAppIconFetched(const GURL icon_url, const SkBitmap& bitmap);
167 168
168 // content::WebContentsObserver overrides 169 // content::WebContentsObserver overrides
169 void DidFinishNavigation(content::NavigationHandle* handle) override; 170 void DidFinishNavigation(content::NavigationHandle* handle) override;
170 void WebContentsDestroyed() override; 171 void WebContentsDestroyed() override;
171 172
(...skipping 10 matching lines...) Expand all
182 std::map<IconParams, IconProperty> icons_; 183 std::map<IconParams, IconProperty> icons_;
183 184
184 bool is_active_; 185 bool is_active_;
185 186
186 base::WeakPtrFactory<InstallableManager> weak_factory_; 187 base::WeakPtrFactory<InstallableManager> weak_factory_;
187 188
188 DISALLOW_COPY_AND_ASSIGN(InstallableManager); 189 DISALLOW_COPY_AND_ASSIGN(InstallableManager);
189 }; 190 };
190 191
191 #endif // CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_ 192 #endif // CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698