Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4861)

Unified Diff: chrome/browser/installable/installable_logging.cc

Issue 2248293002: Do not install WebAPKs with web manifests with invalid URL components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/installable/installable_logging.cc
diff --git a/chrome/browser/installable/installable_logging.cc b/chrome/browser/installable/installable_logging.cc
index 8e54ce0a5918f67360e23ad28c38576f9114f828..15b79af6edb0ae28ff241def83c68513c6a5d949 100644
--- a/chrome/browser/installable/installable_logging.cc
+++ b/chrome/browser/installable/installable_logging.cc
@@ -34,6 +34,8 @@ static const char kManifestEmptyMessage[] =
"the manifest could not be fetched, is empty, or could not be parsed";
static const char kStartUrlNotValidMessage[] =
"the start URL in manifest is not valid";
+static const char kUrlUsernameAndPasswordNotSupportedMessage[] =
dominickn 2016/08/17 22:54:43 Move to the end to match the order in the enum. Al
+ "usernames and passwords in URLs in the web manifest are not supported";
static const char kManifestMissingNameOrShortNameMessage[] =
"one of manifest name or short name must be specified";
static const char kManifestDisplayNotSupportedMessage[] =
@@ -109,6 +111,9 @@ void LogErrorToConsole(content::WebContents* web_contents,
case START_URL_NOT_VALID:
pattern = kStartUrlNotValidMessage;
break;
+ case URL_USERNAME_AND_PASSWORD_NOT_SUPPORTED:
+ pattern = kUrlUsernameAndPasswordNotSupportedMessage;
+ break;
case MANIFEST_MISSING_NAME_OR_SHORT_NAME:
pattern = kManifestMissingNameOrShortNameMessage;
break;

Powered by Google App Engine
This is Rietveld 408576698