Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Issue 2248163002: Allow remapping modifier keys to Caps Lock and Backspace (Closed)

Created:
4 years, 4 months ago by michaelpg
Modified:
4 years, 4 months ago
Reviewers:
stevenjb, kpschoedel
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow remapping modifier keys to Caps Lock and Backspace I've found no reason to disallow remapping Ctrl, Alt or Diamond to the Caps Lock or Backspace keys. This adds them to the dropdown menus in Options (MD Settings to come). BUG=608625 Committed: https://crrev.com/bf2df88ff67f1b3837615d502d189775a46e4e8b Cr-Commit-Position: refs/heads/master@{#412363}

Patch Set 1 #

Patch Set 2 : unit_test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M chrome/browser/chromeos/events/event_rewriter.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
michaelpg
PTAL at this small CL to remove the restriction on remapping to Caps Lock and ...
4 years, 4 months ago (2016-08-16 20:51:12 UTC) #2
stevenjb
lgtm
4 years, 4 months ago (2016-08-16 21:01:56 UTC) #3
kpschoedel
lgtm
4 years, 4 months ago (2016-08-16 21:05:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248163002/20001
4 years, 4 months ago (2016-08-16 21:39:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 22:38:50 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 22:41:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf2df88ff67f1b3837615d502d189775a46e4e8b
Cr-Commit-Position: refs/heads/master@{#412363}

Powered by Google App Engine
This is Rietveld 408576698