Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8253)

Unified Diff: chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

Issue 2248163002: Allow remapping modifier keys to Caps Lock and Backspace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unit_test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/events/event_rewriter.cc ('k') | chrome/common/pref_names.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc b/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
index b234d695179ec932cc4e37256324c859159bed94..edb82135564dff766c4c1086c829527042eb1378 100644
--- a/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
@@ -132,14 +132,6 @@ void KeyboardHandler::GetLocalizedValues(
const input_method::ModifierKey value =
kModifierKeysSelectItems[j].value;
const int message_id = kModifierKeysSelectItems[j].message_id;
- // Only the seach/caps-lock key can be remapped to the
- // caps-lock/backspace key.
- if (kDataValuesNames[i] != std::string("remapSearchKeyToValue") &&
- kDataValuesNames[i] != std::string("remapCapsLockKeyToValue") &&
- (value == input_method::kCapsLockKey ||
- value == input_method::kBackspaceKey)) {
- continue;
- }
base::ListValue* option = new base::ListValue();
option->Append(new base::FundamentalValue(value));
option->Append(new base::StringValue(l10n_util::GetStringUTF16(
« no previous file with comments | « chrome/browser/chromeos/events/event_rewriter.cc ('k') | chrome/common/pref_names.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698