Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: content/browser/accessibility/browser_accessibility_win_unittest.cc

Issue 224803005: Refactor BrowserAccessibility to prepare for AXNode (re-land) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_win_unittest.cc
diff --git a/content/browser/accessibility/browser_accessibility_win_unittest.cc b/content/browser/accessibility/browser_accessibility_win_unittest.cc
index 42b211b249698ee012b2fe6173a2739bcd79ed6a..f7bf9f4a00d272dc7c5fd7eaf7e9dd89b243d61f 100644
--- a/content/browser/accessibility/browser_accessibility_win_unittest.cc
+++ b/content/browser/accessibility/browser_accessibility_win_unittest.cc
@@ -618,9 +618,9 @@ TEST_F(BrowserAccessibilityTest, TestCreateEmptyDocument) {
// Verify the root is as we expect by default.
BrowserAccessibility* root = manager->GetRoot();
- EXPECT_EQ(0, root->renderer_id());
- EXPECT_EQ(ui::AX_ROLE_ROOT_WEB_AREA, root->role());
- EXPECT_EQ(busy_state | readonly_state | enabled_state, root->state());
+ EXPECT_EQ(0, root->GetId());
+ EXPECT_EQ(ui::AX_ROLE_ROOT_WEB_AREA, root->GetRole());
+ EXPECT_EQ(busy_state | readonly_state | enabled_state, root->GetState());
// Tree with a child textfield.
ui::AXNodeData tree1_1;
@@ -649,8 +649,8 @@ TEST_F(BrowserAccessibilityTest, TestCreateEmptyDocument) {
EXPECT_NE(root, manager->GetRoot());
// And the proper child remains.
- EXPECT_EQ(ui::AX_ROLE_TEXT_FIELD, acc1_2->role());
- EXPECT_EQ(2, acc1_2->renderer_id());
+ EXPECT_EQ(ui::AX_ROLE_TEXT_FIELD, acc1_2->GetRole());
+ EXPECT_EQ(2, acc1_2->GetId());
// Tree with a child button.
ui::AXNodeData tree2_1;
@@ -676,8 +676,8 @@ TEST_F(BrowserAccessibilityTest, TestCreateEmptyDocument) {
EXPECT_NE(root, manager->GetRoot());
// And the new child exists.
- EXPECT_EQ(ui::AX_ROLE_BUTTON, acc2_2->role());
- EXPECT_EQ(3, acc2_2->renderer_id());
+ EXPECT_EQ(ui::AX_ROLE_BUTTON, acc2_2->GetRole());
+ EXPECT_EQ(3, acc2_2->GetId());
// Ensure we properly cleaned up.
manager.reset();
@@ -705,7 +705,7 @@ TEST(BrowserAccessibilityManagerWinTest, TestAccessibleHWND) {
// Enabling screen reader support and calling MaybeCallNotifyWinEvent
// should trigger creating the AccessibleHWND, and we should now get a
- // new parent_hwnd with the right window class to fool older screen
+ // new GetParent()hwnd with the right window class to fool older screen
// readers.
BrowserAccessibilityStateImpl::GetInstance()->OnScreenReaderDetected();
manager->MaybeCallNotifyWinEvent(0, 0);
@@ -715,7 +715,7 @@ TEST(BrowserAccessibilityManagerWinTest, TestAccessibleHWND) {
ASSERT_NE(0, GetClassName(new_parent_hwnd, hwnd_class_name, 256));
ASSERT_STREQ(L"Chrome_RenderWidgetHostHWND", hwnd_class_name);
- // Destroy the hwnd explicitly; that should trigger clearing parent_hwnd().
+ // Destroy the hwnd explicitly; that should trigger clearing GetParent()hwnd().
DestroyWindow(new_parent_hwnd);
ASSERT_EQ(NULL, manager->parent_hwnd());

Powered by Google App Engine
This is Rietveld 408576698