Refactor BrowserAccessibility to prepare for AXNode (re-land)

content/browser/accessibility/browser_accessibility_win_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/scoped_bstr.h"
 #include "base/win/scoped_comptr.h"
 #include "base/win/scoped_variant.h"
 #include "content/browser/accessibility/browser_accessibility_manager.h"
@@ skipping 600 matching lines @@
   scoped_ptr<BrowserAccessibilityManager> manager(
       new BrowserAccessibilityManagerWin(
           accessible_hwnd.get(),
           NULL,
           BrowserAccessibilityManagerWin::GetEmptyDocument(),
           NULL,
           new CountedBrowserAccessibilityFactory()));
 
   // Verify the root is as we expect by default.
   BrowserAccessibility* root = manager->GetRoot();
-  EXPECT_EQ(0, root->renderer_id());
-  EXPECT_EQ(ui::AX_ROLE_ROOT_WEB_AREA, root->role());
-  EXPECT_EQ(busy_state | readonly_state | enabled_state, root->state());
+  EXPECT_EQ(0, root->GetId());
+  EXPECT_EQ(ui::AX_ROLE_ROOT_WEB_AREA, root->GetRole());
+  EXPECT_EQ(busy_state | readonly_state | enabled_state, root->GetState());
 
   // Tree with a child textfield.
   ui::AXNodeData tree1_1;
   tree1_1.id = 1;
   tree1_1.role = ui::AX_ROLE_ROOT_WEB_AREA;
   tree1_1.child_ids.push_back(2);
 
   ui::AXNodeData tree1_2;
   tree1_2.id = 2;
   tree1_2.role = ui::AX_ROLE_TEXT_FIELD;
 
   // Process a load complete.
   std::vector<AccessibilityHostMsg_EventParams> params;
   params.push_back(AccessibilityHostMsg_EventParams());
   AccessibilityHostMsg_EventParams* msg = &params[0];
   msg->event_type = ui::AX_EVENT_LOAD_COMPLETE;
   msg->update.nodes.push_back(tree1_1);
   msg->update.nodes.push_back(tree1_2);
   msg->id = tree1_1.id;
   manager->OnAccessibilityEvents(params);
 
   // Save for later comparison.
   BrowserAccessibility* acc1_2 = manager->GetFromRendererID(2);
 
   // Verify the root has changed.
   EXPECT_NE(root, manager->GetRoot());
 
   // And the proper child remains.
-  EXPECT_EQ(ui::AX_ROLE_TEXT_FIELD, acc1_2->role());
-  EXPECT_EQ(2, acc1_2->renderer_id());
+  EXPECT_EQ(ui::AX_ROLE_TEXT_FIELD, acc1_2->GetRole());
+  EXPECT_EQ(2, acc1_2->GetId());
 
   // Tree with a child button.
   ui::AXNodeData tree2_1;
   tree2_1.id = 1;
   tree2_1.role = ui::AX_ROLE_ROOT_WEB_AREA;
   tree2_1.child_ids.push_back(3);
 
   ui::AXNodeData tree2_2;
   tree2_2.id = 3;
   tree2_2.role = ui::AX_ROLE_BUTTON;
 
   msg->update.nodes.clear();
   msg->update.nodes.push_back(tree2_1);
   msg->update.nodes.push_back(tree2_2);
   msg->id = tree2_1.id;
 
   // Fire another load complete.
   manager->OnAccessibilityEvents(params);
 
   BrowserAccessibility* acc2_2 = manager->GetFromRendererID(3);
 
   // Verify the root has changed.
   EXPECT_NE(root, manager->GetRoot());
 
   // And the new child exists.
-  EXPECT_EQ(ui::AX_ROLE_BUTTON, acc2_2->role());
-  EXPECT_EQ(3, acc2_2->renderer_id());
+  EXPECT_EQ(ui::AX_ROLE_BUTTON, acc2_2->GetRole());
+  EXPECT_EQ(3, acc2_2->GetId());
 
   // Ensure we properly cleaned up.
   manager.reset();
   ASSERT_EQ(0, CountedBrowserAccessibility::num_instances());
 }
 
 TEST(BrowserAccessibilityManagerWinTest, TestAccessibleHWND) {
   HWND desktop_hwnd = GetDesktopWindow();
   base::win::ScopedComPtr<IAccessible> desktop_hwnd_iaccessible;
   ASSERT_EQ(S_OK, AccessibleObjectFromWindow(
       desktop_hwnd, OBJID_CLIENT,
       IID_IAccessible,
       reinterpret_cast<void**>(desktop_hwnd_iaccessible.Receive())));
 
   scoped_ptr<content::LegacyRenderWidgetHostHWND> accessible_hwnd(
       content::LegacyRenderWidgetHostHWND::Create(GetDesktopWindow()));
 
   scoped_ptr<BrowserAccessibilityManagerWin> manager(
       new BrowserAccessibilityManagerWin(
           accessible_hwnd.get(),
           desktop_hwnd_iaccessible,
           BrowserAccessibilityManagerWin::GetEmptyDocument(),
           NULL));
   ASSERT_EQ(desktop_hwnd, manager->parent_hwnd());
 
   // Enabling screen reader support and calling MaybeCallNotifyWinEvent
   // should trigger creating the AccessibleHWND, and we should now get a
-  // new parent_hwnd with the right window class to fool older screen
+  // new GetParent()hwnd with the right window class to fool older screen
   // readers.
   BrowserAccessibilityStateImpl::GetInstance()->OnScreenReaderDetected();
   manager->MaybeCallNotifyWinEvent(0, 0);
   HWND new_parent_hwnd = manager->parent_hwnd();
   ASSERT_NE(desktop_hwnd, new_parent_hwnd);
   WCHAR hwnd_class_name[256];
   ASSERT_NE(0, GetClassName(new_parent_hwnd, hwnd_class_name, 256));
   ASSERT_STREQ(L"Chrome_RenderWidgetHostHWND", hwnd_class_name);
 
-  // Destroy the hwnd explicitly; that should trigger clearing parent_hwnd().
+  // Destroy the hwnd explicitly; that should trigger clearing GetParent()hwnd().
   DestroyWindow(new_parent_hwnd);
   ASSERT_EQ(NULL, manager->parent_hwnd());
 
   // Now create it again.
   accessible_hwnd = content::LegacyRenderWidgetHostHWND::Create(
       GetDesktopWindow());
   manager.reset(
       new BrowserAccessibilityManagerWin(
           accessible_hwnd.get(),
           desktop_hwnd_iaccessible,
           BrowserAccessibilityManagerWin::GetEmptyDocument(),
           NULL));
   manager->MaybeCallNotifyWinEvent(0, 0);
   new_parent_hwnd = manager->parent_hwnd();
   ASSERT_FALSE(NULL == new_parent_hwnd);
 
   // This time, destroy the manager first, make sure the AccessibleHWND doesn't
   // crash on destruction (to be caught by SyzyASAN or other tools).
   manager.reset(NULL);
 }
 
 }  // namespace content