Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2247773004: [WIP] CSS Motion Path: offset-anchor and offset-position

Created:
4 years, 4 months ago by Eric Willigers
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] CSS Motion Path: offset-anchor and offset-position offset-position is the initial position of the path in the containing element. https://drafts.fxtf.org/motion-1/#offset-position-property offset-anchor is the point in the element that is positioned along the path. https://drafts.fxtf.org/motion-1/#offset-anchor-property The offset shorthand is also updated: https://drafts.fxtf.org/motion-1/#motion-shorthand BUG=638055

Patch Set 1 #

Patch Set 2 : shorthand parsing #

Patch Set 3 : parsing #

Patch Set 4 : relative #

Patch Set 5 : passes #

Patch Set 6 : offsetPosition #

Patch Set 7 : offsetAnchor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1214 lines, -602 lines) Patch
A + third_party/WebKit/LayoutTests/animations/composition/offset-anchor-composition.html View 1 2 5 chunks +12 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/composition/offset-distance-composition.html View 1 2 4 4 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/composition/offset-position-composition.html View 1 2 5 chunks +12 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/composition/offset-rotation-composition.html View 1 2 4 6 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/interpolation/offset-anchor-interpolation.html View 1 5 chunks +30 lines, -36 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/interpolation/offset-distance-interpolation.html View 1 2 4 7 chunks +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/interpolation/offset-position-interpolation.html View 1 5 chunks +30 lines, -36 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/interpolation/offset-rotation-interpolation.html View 1 2 4 10 chunks +13 lines, -13 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/responsive/offset-rotation-responsive.html View 1 2 4 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/combine-anchor-distance.html View 1 2 3 4 5 6 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/combine-anchor-distance-expected.html View 1 2 3 4 5 6 1 chunk +19 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/motion-path/combine-motion-translation-and-rotation.html View 1 2 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/motion-path/combine-motion-translation-and-rotation-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/motion-path/combine-offset-translation-and-rotation.html View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/css3/motion-path/combine-offset-translation-and-rotation-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/combine-position-distance.html View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/combine-position-distance-expected.html View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/motion-path/combine-rotation.html View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css3/motion-path/combine-translation.html View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/css3/motion-path/combine-translation-and-rotation.html View 1 2 4 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/motion-path/combine-translation-and-rotation-expected.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/motion-path/compute-distance.html View 1 2 4 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/motion-path/motion-rotation-overflow-crash.html View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/offset.html View 1 2 3 4 1 chunk +180 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/offset-anchor.html View 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/offset-distance.html View 1 2 4 1 chunk +71 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/offset-path.html View 1 2 4 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/offset-position.html View 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/offset-rotation.html View 1 2 4 1 chunk +96 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/motion-path/path-establishes-stacking-context.html View 1 2 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/motion-path/zero-length.html View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/fast/css/getComputedStyle/computed-style-listing-expected.txt View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/css/getComputedStyle-listing-expected.txt View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/transforms/perspective-origin-parsing.html View 1 2 3 4 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/animation/CSSMotionRotationInterpolationType.h View 1 2 3 4 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/Source/core/animation/CSSMotionRotationInterpolationType.cpp View 1 2 4 1 chunk +0 lines, -147 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.cpp View 1 2 3 4 2 chunks +42 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPositionInterpolationType.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffect.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp View 1 2 3 4 3 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 1 2 3 4 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 2 3 4 5 6 2 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp View 1 2 4 2 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 3 4 4 chunks +27 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 6 chunks +19 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp View 1 2 3 4 5 4 chunks +64 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 2 3 4 2 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h View 1 2 4 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 2 3 4 2 chunks +14 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 2 3 4 3 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 4 5 6 5 chunks +26 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 4 5 6 6 chunks +25 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleMotionData.h View 1 2 4 3 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleMotionData.cpp View 1 chunk +4 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/style/StyleMotionRotation.h View 1 2 4 1 chunk +0 lines, -31 lines 0 comments Download
A + third_party/WebKit/Source/core/style/StyleOffsetRotation.h View 1 2 3 4 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleTransformData.cpp View 1 2 4 1 chunk +6 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (8 generated)
Eric Willigers
The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-17 05:51:01 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247773004/40001
4 years, 4 months ago (2016-08-17 05:51:26 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-17 05:54:11 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/252567)
4 years, 4 months ago (2016-08-17 05:54:12 UTC) #4
Eric Willigers
The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-22 04:23:06 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247773004/80001
4 years, 4 months ago (2016-08-22 04:23:15 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-22 06:09:53 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 06:09:54 UTC) #8 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698