third_party/WebKit/Source/core/animation/CSSPositionInterpolationType.h - Issue 2247773004: [WIP] CSS Motion Path: offset-anchor and offset-position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSPositionInterpolationType.h

Issue 2247773004: [WIP] CSS Motion Path: offset-anchor and offset-position Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: offsetAnchor Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/KeyframeEffect.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSPositionInterpolationType.h

diff --git a/third_party/WebKit/Source/core/animation/CSSPositionInterpolationType.h b/third_party/WebKit/Source/core/animation/CSSPositionInterpolationType.h

index 523542e0b575ea3fae5693fa19166742c32261a0..8ff2a7a2770ebbdefc3da858f6e406dbb254be29 100644

--- a/third_party/WebKit/Source/core/animation/CSSPositionInterpolationType.h

+++ b/third_party/WebKit/Source/core/animation/CSSPositionInterpolationType.h

@@ -22,6 +22,10 @@ public:

private:

InterpolationValue maybeConvertValue(const CSSValue& value, const StyleResolverState&, ConversionCheckers&) const final

{

+ if (value.isPrimitiveValue()) {

+ DCHECK(toCSSPrimitiveValue(value).getValueID() == CSSValueAuto);

+ return nullptr;

+ }

const CSSValuePair& pair = toCSSValuePair(value);

return ListInterpolationFunctions::createList(2, [&pair](size_t index) {

return CSSPositionAxisListInterpolationType::convertPositionAxisCSSValue(index == 0 ? pair.first() : pair.second());