ChromeOS: Implement EULA screen of material design OOBE.

ChromeOS: Implement EULA screen of material design OOBE.

This CL adds EULA screen to material design OOBE.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7e40f625dc05c8932f66064cb9059c467cd27034
Cr-Commit-Position: refs/heads/master@{#412438}

[Alexander Alekseev, 2016-08-15 12:15:09]

Description was changed from

==========
ChromeOS: Implement EULA screen of material design OOBE.

This CL adds EULA screen to material design OOBE.

BUG=604119
TEST=none
==========

to

==========
ChromeOS: Implement EULA screen of material design OOBE.

This CL adds EULA screen to material design OOBE.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Alexander Alekseev, 2016-08-15 12:18:01]

alemate@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Alexander Alekseev, 2016-08-15 12:18:02]

Please review.

[Alexander Alekseev, 2016-08-15 12:18:09]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 12:18:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 13:08:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 13:08:57]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-08-15 16:16:50]

https://codereview.chromium.org/2247723002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:1723: ACCEPT AND CONTINUE
use sentence case, and capitalize with CSS if necessary

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_dialog_host.css (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_dialog_host.css:2: Use of this
source code is governed by a BSD-style license that can be
see other examples of CSS copyright header, e.g.
https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/...

/* Copyright 2016
 * Use of this
 * found in the LICENSE file. */

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_dialog_host.css:10: 
nit: remove blank line

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_eula.css (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_eula.css:8: 
nit: remove blank line

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_eula.html (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_eula.html:39: </h1>
nit: on previous line if it fits

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_eula.html:58: 
remove both blank lines

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_eula.js (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_eula.js:54: * This is 'on-tap'
event handler for "Accept' button.
nit: matching quotes

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_screen_eula.css (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_eula.css:109: visibility:
hidden;
use display: none
also, don't you also do this from JavaScript?

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_eula.css:114: visibility:
visible;
same comments

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_screen_eula.html (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_eula.html:4: <oobe-eula-md
id="oobe-eula-md" class="fit">
nit: </ on same line if it fits

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_eula.html:47:
class="credits"><a id="eula-chrome-credits-link" href="#"
why is this all mashed together

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_screen_network.css (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_network.css:12: padding: 0 0
0;
padding: 0;

https://codereview.chromium.org/2247723002/diff/1/ui/login/display_manager.js
File ui/login/display_manager.js (right):

https://codereview.chromium.org/2247723002/diff/1/ui/login/display_manager.js...
ui/login/display_manager.js:715: /* Recalculate all MD containers */
why? and AFAICT there's only 1

https://codereview.chromium.org/2247723002/diff/1/ui/login/display_manager.js...
ui/login/display_manager.js:722: width = Math.max(width,
children[j].offsetWidth);
offsetWidth or clientWidth?

[Alexander Alekseev, 2016-08-15 19:36:43]

https://codereview.chromium.org/2247723002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:1723: ACCEPT AND CONTINUE
On 2016/08/15 16:16:49, michaelpg wrote:
> use sentence case, and capitalize with CSS if necessary

This comes from design mocks.

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_dialog_host.css (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_dialog_host.css:2: Use of this
source code is governed by a BSD-style license that can be
On 2016/08/15 16:16:49, michaelpg wrote:
> see other examples of CSS copyright header, e.g.
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/...
> 
> /* Copyright 2016
>  * Use of this
>  * found in the LICENSE file. */

Done.

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_dialog_host.css:10: 
On 2016/08/15 16:16:49, michaelpg wrote:
> nit: remove blank line

Done.

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_eula.css (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_eula.css:8: 
On 2016/08/15 16:16:49, michaelpg wrote:
> nit: remove blank line

Done.

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_eula.html (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_eula.html:39: </h1>
On 2016/08/15 16:16:49, michaelpg wrote:
> nit: on previous line if it fits

Done.

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_eula.html:58: 
On 2016/08/15 16:16:49, michaelpg wrote:
> remove both blank lines

Done.

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_eula.js (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_eula.js:54: * This is 'on-tap'
event handler for "Accept' button.
On 2016/08/15 16:16:49, michaelpg wrote:
> nit: matching quotes

Done.

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_screen_eula.css (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_eula.css:109: visibility:
hidden;
On 2016/08/15 16:16:49, michaelpg wrote:
> use display: none
> also, don't you also do this from JavaScript?

This was part of an experiment.
"display: none" will not create elements, and JS initialization will fail. (So I
removed this code.)

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_screen_eula.html (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_eula.html:4: <oobe-eula-md
id="oobe-eula-md" class="fit">
On 2016/08/15 16:16:49, michaelpg wrote:
> nit: </ on same line if it fits

Done.

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_eula.html:47:
class="credits"><a id="eula-chrome-credits-link" href="#"
On 2016/08/15 16:16:49, michaelpg wrote:
> why is this all mashed together

This is actually a problem of upload. I only put old code inside <div
id="oobe-eula"> and didn't change it. I'll try to re-upload this CL with better
diff.

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_screen_network.css (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_network.css:12: padding: 0 0
0;
On 2016/08/15 16:16:50, michaelpg wrote:
> padding: 0;

Done.

https://codereview.chromium.org/2247723002/diff/1/ui/login/display_manager.js
File ui/login/display_manager.js (right):

https://codereview.chromium.org/2247723002/diff/1/ui/login/display_manager.js...
ui/login/display_manager.js:715: /* Recalculate all MD containers */
On 2016/08/15 16:16:50, michaelpg wrote:
> why? and AFAICT there's only 1

This code was needed because MD elements had 'position: absolute'.
I updated layout and it is not needed anymore.

[Alexander Alekseev, 2016-08-15 19:36:49]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 19:37:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 20:32:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:32:22]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-08-17 00:24:44]

https://codereview.chromium.org/2247723002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:1723: ACCEPT AND CONTINUE
On 2016/08/15 19:36:42, Alexander Alekseev wrote:
> On 2016/08/15 16:16:49, michaelpg wrote:
> > use sentence case, and capitalize with CSS if necessary
> 
> This comes from design mocks.

still, use sentence case, and capitalize with CSS

https://codereview.chromium.org/2247723002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe.js (right):

https://codereview.chromium.org/2247723002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe.js:325:
$('oobe').setAttribute('md-mode', true);
nit: attribute values are strings ('true')

https://codereview.chromium.org/2247723002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_dialog_host.css (right):

https://codereview.chromium.org/2247723002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog_host.css:1: /* Copyright
2015 The Chromium Authors. All rights reserved.
don't copy & paste the year if you're adding a new file....

https://codereview.chromium.org/2247723002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_eula.css (right):

https://codereview.chromium.org/2247723002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_eula.css:1: /* Copyright 2015 The
Chromium Authors. All rights reserved.
year

https://codereview.chromium.org/2247723002/diff/20001/ui/login/screen_contain...
File ui/login/screen_container.css (right):

https://codereview.chromium.org/2247723002/diff/20001/ui/login/screen_contain...
ui/login/screen_container.css:68: }
nit: newline after block

https://codereview.chromium.org/2247723002/diff/20001/ui/login/screen_contain...
ui/login/screen_container.css:122: visibility:hidden;
nit: space after :

[Alexander Alekseev, 2016-08-17 01:10:45]

https://codereview.chromium.org/2247723002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2247723002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:1723: ACCEPT AND CONTINUE
On 2016/08/17 00:24:44, michaelpg wrote:
> On 2016/08/15 19:36:42, Alexander Alekseev wrote:
> > On 2016/08/15 16:16:49, michaelpg wrote:
> > > use sentence case, and capitalize with CSS if necessary
> > 
> > This comes from design mocks.
> 
> still, use sentence case, and capitalize with CSS

Done.

https://codereview.chromium.org/2247723002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe.js (right):

https://codereview.chromium.org/2247723002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe.js:325:
$('oobe').setAttribute('md-mode', true);
On 2016/08/17 00:24:44, michaelpg wrote:
> nit: attribute values are strings ('true')

Done.

https://codereview.chromium.org/2247723002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_dialog_host.css (right):

https://codereview.chromium.org/2247723002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog_host.css:1: /* Copyright
2015 The Chromium Authors. All rights reserved.
On 2016/08/17 00:24:44, michaelpg wrote:
> don't copy & paste the year if you're adding a new file....

Done. 

;)

https://codereview.chromium.org/2247723002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_eula.css (right):

https://codereview.chromium.org/2247723002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_eula.css:1: /* Copyright 2015 The
Chromium Authors. All rights reserved.
On 2016/08/17 00:24:44, michaelpg wrote:
> year

Done.

https://codereview.chromium.org/2247723002/diff/20001/ui/login/screen_contain...
File ui/login/screen_container.css (right):

https://codereview.chromium.org/2247723002/diff/20001/ui/login/screen_contain...
ui/login/screen_container.css:68: }
On 2016/08/17 00:24:44, michaelpg wrote:
> nit: newline after block

Done.

https://codereview.chromium.org/2247723002/diff/20001/ui/login/screen_contain...
ui/login/screen_container.css:122: visibility:hidden;
On 2016/08/17 00:24:44, michaelpg wrote:
> nit: space after :

Done.

[Alexander Alekseev, 2016-08-17 01:10:55]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 01:11:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-08-17 01:59:47]

lgtm

[commit-bot: I haz the power, 2016-08-17 02:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 02:15:25]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-08-17 03:02:05]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-08-17 03:02:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 03:06:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-17 03:08:47]

Description was changed from

==========
ChromeOS: Implement EULA screen of material design OOBE.

This CL adds EULA screen to material design OOBE.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS: Implement EULA screen of material design OOBE.

This CL adds EULA screen to material design OOBE.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7e40f625dc05c8932f66064cb9059c467cd27034
Cr-Commit-Position: refs/heads/master@{#412438}
==========

[commit-bot: I haz the power, 2016-08-17 03:08:49]

Patchset 3 (id:??) landed as
https://crrev.com/7e40f625dc05c8932f66064cb9059c467cd27034
Cr-Commit-Position: refs/heads/master@{#412438}