chrome/browser/resources/chromeos/login/oobe_screen_eula.html - Issue 2247723002: ChromeOS: Implement EULA screen of material design OOBE.

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe_screen_eula.html

Issue 2247723002: ChromeOS: Implement EULA screen of material design OOBE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/chromeos/login/oobe_screen_eula.css ('K') | « chrome/browser/resources/chromeos/login/oobe_screen_eula.css ('k') | chrome/browser/resources/chromeos/login/oobe_screen_eula.js » ('j') | chrome/browser/resources/chromeos/login/oobe_screen_network.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div class="step right hidden animated eula-loading" id="eula" role="group"	1 <div class="step right hidden animated eula-loading" id="eula" role="group"

2 i18n-values="aria-label:eulaScreenAccessibleTitle" hidden>	2 i18n-values="aria-label:eulaScreenAccessibleTitle" hidden>

3 <div class="step-contents">	3 <div id="oobe-poly-eula" hidden>

4 <div id="eulas" class="eula-columns one-column">	4 <oobe-eula-md id="oobe-eula-md" class="fit">
	michaelpg 2016/08/15 16:16:49 nit: </ on same line if it fits nit: </ on same line if it fits Alexander Alekseev 2016/08/15 19:36:43 Done. Show quoted text On 2016/08/15 16:16:49, michaelpg wrote: > nit: </ on same line if it fits Done.
5 <div id="cros-eula" tabindex="0">	5 </oobe-eula-md>

6 <iframe id="cros-eula-frame" name="cros-eula-frame" class="eula-frame"	6 </div>

7 src="about:blank"></iframe>	7 <div id="oobe-eula">

8 <div id="cros-eula-loading">	8 <div class="step-contents">

9 <div>	9 <div id="eulas" class="eula-columns one-column">

10 <p i18n-content="termsOfServiceLoading"></p>	10 <div id="cros-eula" tabindex="0">

	11 <iframe id="cros-eula-frame" name="cros-eula-frame" class="eula-frame"

	12 src="about:blank"></iframe>

	13 <div id="cros-eula-loading">

	14 <div>

	15 <p i18n-content="termsOfServiceLoading"></p>

	16 </div>

11 </div>	17 </div>

12 </div>	18 </div>

	19 <div id="oem-eula">

	20 <iframe id="oem-eula-frame" name="oem-eula-frame" class="eula-frame">

	21 </iframe>

	22 </div>

13 </div>	23 </div>

14 <div id="oem-eula">	24 <div id="logging">

15 <iframe id="oem-eula-frame" name="oem-eula-frame" class="eula-frame"></i frame>	25 <div>

	26 <input aria-labelledby="usage-stats-label" id="usage-stats"

	27 type="checkbox">

	28 </div>

	29 <div>

	30 <label id="usage-stats-label" i18n-content="checkboxLogging"></label>

	31 <a id="stats-help-link" href="#" i18n-content="learnMore"></a>

	32 </div>

16 </div>	33 </div>

17 </div>	34 </div>

18 <div id="logging">	35 <div id="eula-controls" class="step-controls"></div>

19 <div>	36 <div id="eula-extra-controls" class="step-extra-controls">

20 <input id="usage-stats" type="checkbox">	37 <div id="installation-settings">

	38 <a id="installation-settings-link" href="#"

	39 i18n-content="eulaSystemInstallationSettings">

	40 </a>

21 </div>	41 </div>

22 <div>	42 <div id="eula-accessibility">

23 <label for="usage-stats" i18n-content="checkboxLogging"></label>	43 <a id="eula-accessibility-link" href="#" role="button"

24 <a id="stats-help-link" href="#" i18n-content="learnMore"></a>	44 i18n-content="accessibilityLink"></a>

25 </div>	45 </div>

	46 <div id="eula-chrome-credits"

	47 class="credits"><a id="eula-chrome-credits-link" href="#"
	michaelpg 2016/08/15 16:16:49 why is this all mashed together why is this all mashed together Alexander Alekseev 2016/08/15 19:36:43 This is actually a problem of upload. I only put o Show quoted text On 2016/08/15 16:16:49, michaelpg wrote: > why is this all mashed together This is actually a problem of upload. I only put old code inside <div id="oobe-eula"> and didn't change it. I'll try to re-upload this CL with better diff.
	48 role="button" i18n-content="chromeCreditsLink"></a></div>

	49 <div id="eula-chromeos-credits"

	50 class="credits"><a id="eula-chromeos-credits-link" href="#"

	51 role="button" i18n-content="chromeosCreditsLink"></a></div>

	52 </div>

	53 <div id="eula-busy" class="step-loading">

	54 <div class="throbber"></div>

26 </div>	55 </div>

27 </div>	56 </div>

28 <div id="eula-controls" class="step-controls"></div>

29 <div id="eula-extra-controls" class="step-extra-controls">

30 <div id="installation-settings">

31 <a id="installation-settings-link" href="#"

32 i18n-content="eulaSystemInstallationSettings">

33 </a>

34 </div>

35 <div id="eula-accessibility">

36 <a id="eula-accessibility-link" href="#" role="button"

37 i18n-content="accessibilityLink"></a>

38 </div>

39 <div id="eula-chrome-credits"

40 class="credits"><a id="eula-chrome-credits-link" href="#" role="button"

41 i18n-content="chromeCreditsLink"></a></div>

42 <div id="eula-chromeos-credits"

43 class="credits"><a id="eula-chromeos-credits-link" href="#" role="button"

44 i18n-content="chromeosCreditsLink"></a></div>

45 </div>

46 <div id="eula-busy" class="step-loading">

47 <div class="throbber"></div>

48 </div>

49 </div>	57 </div>

OLD	NEW