Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2235)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/compiler_specific.h

Issue 224763005: win: Now that we're on msvs2013, spell final 'final' not 'sealed'. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sigh Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/compiler_specific.h
diff --git a/base/compiler_specific.h b/base/compiler_specific.h
index 16837dff479fcbca7b2a3109d9ef473bc78565df..f4f9a11f2e00d6422e6a876e290be5f9b90124b9 100644
--- a/base/compiler_specific.h
+++ b/base/compiler_specific.h
@@ -157,8 +157,10 @@
#if defined(__clang__)
#define FINAL final
#elif defined(COMPILER_MSVC)
-// TODO(jered): Change this to "final" when chromium no longer uses MSVC 2010.
-#define FINAL sealed
+// TODO(thakis): Remove if !defined() once Blink is updated too.
+#if !defined(FINAL)
+#define FINAL final
+#endif
#elif defined(COMPILER_GCC) && __cplusplus >= 201103 && \
(__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40700
// GCC 4.7 supports explicit virtual overrides when C++11 support is enabled.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698