Issue 224753005: Revert 262344 "don't use glibc-specific execinfo.h on uclibc builds"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 224753005: Revert 262344 "don't use glibc-specific execinfo.h on uclibc builds" (Closed)

Created:
6 years, 8 months ago by earthdok

Modified:
6 years, 8 months ago

Reviewers:
Mostyn Bramley-Moore

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 262344 "don't use glibc-specific execinfo.h on uclibc builds" Broken in libc++ builds. BUG=361130 > don't use glibc-specific execinfo.h on uclibc builds > > The execinfo.h header is glibc-specific, as is the backtrace function. > Let's skip them for uclibc builds. > > Review URL: https://codereview.chromium.org/226623008 TBR=mostynb@opera.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262401

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -15 lines)			Patch
M	trunk/src/base/debug/stack_trace.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/base/debug/stack_trace.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/base/debug/stack_trace_posix.cc	View	8 chunks	+5 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

earthdok

Committed patchset #1 manually as r262401 (tree was closed).

6 years, 8 months ago (2014-04-08 14:33:56 UTC) #2

Mostyn Bramley-Moore

The revert looks correct. I think I see the problem: my CL added extra defined(__GLIBCXX__) ...

6 years, 8 months ago (2014-04-08 14:46:26 UTC) #3

earthdok

6 years, 8 months ago (2014-04-08 15:04:11 UTC) #4

Message was sent while issue was closed.

On 2014/04/08 14:46:26, Mostyn Bramley-Moore wrote:
> The revert looks correct.  I think I see the problem: my CL added extra
> defined(__GLIBCXX__) checks that it shouldn't have.

See http://code.google.com/p/chromium/issues/detail?id=361130

Expand Messages | Collapse Messages