Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 226623008: don't use glibc-specific execinfo.h on uclibc builds (Closed)

Created:
6 years, 8 months ago by Mostyn Bramley-Moore
Modified:
6 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

don't use glibc-specific execinfo.h on uclibc builds The execinfo.h header is glibc-specific, as is the backtrace function. Let's skip them for uclibc builds. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262344

Patch Set 1 #

Total comments: 2

Patch Set 2 : ifdef out Print and OutputToStream in uClibc builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M base/debug/stack_trace.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M base/debug/stack_trace.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M base/debug/stack_trace_posix.cc View 1 8 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Mostyn Bramley-Moore
@Mark: PTAL...
6 years, 8 months ago (2014-04-07 19:45:13 UTC) #1
Mark Mentovai
https://codereview.chromium.org/226623008/diff/1/base/debug/stack_trace_posix.cc File base/debug/stack_trace_posix.cc (right): https://codereview.chromium.org/226623008/diff/1/base/debug/stack_trace_posix.cc#newcode752 base/debug/stack_trace_posix.cc:752: PrintBacktraceOutputHandler handler; Do you want to wrap the implementation ...
6 years, 8 months ago (2014-04-07 20:37:12 UTC) #2
Mostyn Bramley-Moore
https://codereview.chromium.org/226623008/diff/1/base/debug/stack_trace_posix.cc File base/debug/stack_trace_posix.cc (right): https://codereview.chromium.org/226623008/diff/1/base/debug/stack_trace_posix.cc#newcode752 base/debug/stack_trace_posix.cc:752: PrintBacktraceOutputHandler handler; On 2014/04/07 20:37:12, Mark Mentovai wrote: > ...
6 years, 8 months ago (2014-04-07 21:00:56 UTC) #3
Mark Mentovai
Nice. LGTM.
6 years, 8 months ago (2014-04-07 21:04:10 UTC) #4
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 8 months ago (2014-04-07 21:06:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/226623008/20001
6 years, 8 months ago (2014-04-07 21:07:14 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 21:36:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 8 months ago (2014-04-07 21:36:17 UTC) #8
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 8 months ago (2014-04-07 22:00:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/226623008/20001
6 years, 8 months ago (2014-04-07 22:01:42 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 22:18:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-07 22:18:00 UTC) #12
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 8 months ago (2014-04-08 07:10:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/226623008/20001
6 years, 8 months ago (2014-04-08 07:10:20 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 08:27:31 UTC) #15
Message was sent while issue was closed.
Change committed as 262344

Powered by Google App Engine
This is Rietveld 408576698