Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2247493002: Enable closing while processing payment. (Closed)

Created:
4 years, 4 months ago by please use gerrit instead
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable closing while processing payment. This patch allows closing PaymentRequest UI via the [x] button while waiting for merchant to process the payment. This is accomplished by switching off the "is processing pay clicked" flag when showProcessingMessage() has been called. PaymentRequestImpl calls showProcessingMessage() when payment app has closed and its info has been sent to the merchant website. BUG=637366 Committed: https://crrev.com/4d72ec4ded66ff9ad99497f5895433bccd179716 Cr-Commit-Position: refs/heads/master@{#411881}

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Fix test #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
A + chrome/android/java/src/org/chromium/chrome/browser/payments/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 2 6 chunks +13 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 1 2 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
please use gerrit instead
dfalcantara, ptal.
4 years, 4 months ago (2016-08-12 20:34:55 UTC) #5
gone
lgtm
4 years, 4 months ago (2016-08-12 21:26:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247493002/40001
4 years, 4 months ago (2016-08-13 06:18:03 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-13 06:21:32 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 06:23:18 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4d72ec4ded66ff9ad99497f5895433bccd179716
Cr-Commit-Position: refs/heads/master@{#411881}

Powered by Google App Engine
This is Rietveld 408576698