Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4445)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Issue 2247493002: Enable closing while processing payment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test #2 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
index 64b3e8c068d0ba8e9f2aa8b484dc2e66abc41891..763957ff8b139ded416c6290f44eecd26a0bf8fb 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
@@ -527,14 +527,12 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
}
};
- if (shouldCloseImmediately || !mIsProcessingPayClicked) {
+ if (shouldCloseImmediately) {
// The shouldCloseImmediately boolean is true when the merchant calls
// instrumentResponse.complete("success") or instrumentResponse.complete("")
// in JavaScript.
dismissRunnable.run();
} else {
- mIsProcessingPayClicked = false;
-
// Animate the bottom sheet going away.
new DisappearingAnimator(false);
@@ -768,6 +766,7 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
*/
public void showProcessingMessage() {
assert mIsProcessingPayClicked;
+ mIsProcessingPayClicked = false;
changeSpinnerVisibility(true);
mDialog.show();
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698