Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: scripts/slave/recipes/bisection/android_bisect.py

Issue 2247373002: Refactor stages 1, 2 and test_api overhaul. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/bisection/android_bisect.py
diff --git a/scripts/slave/recipes/bisection/android_bisect.py b/scripts/slave/recipes/bisection/android_bisect.py
index 3025c304c81629addc7935638f6171f956d39509..8b5c0d364092fc10c0aafb0d732cdc486ee3ca6d 100644
--- a/scripts/slave/recipes/bisection/android_bisect.py
+++ b/scripts/slave/recipes/bisection/android_bisect.py
@@ -401,12 +401,6 @@ results-without_patch
path_config='kitchen',
mastername='tryserver.chromium.perf',
buildername=buildername) +
- api.step_data(
- 'saving url to temp file',
- stdout=api.raw_io.output('/tmp/dummy1')) +
- api.step_data(
- 'saving json to temp file',
- stdout=api.raw_io.output('/tmp/dummy2')) +
api.properties(
bisect_config=bisect_config) + api.properties(
job_name='f7a7b4135624439cbd27fdd5133d74ec') +
@@ -563,12 +557,6 @@ results-without_patch
parent_got_revision='1111111',
parent_build_archive_url='gs://test-domain/test-archive.zip') +
api.bisect_tester(tempfile='/tmp/dummy') +
- api.step_data(
- 'Gathering reference values.saving json to temp file',
- stdout=api.raw_io.output('/tmp/dummy3')) +
- api.step_data(
- 'Gathering reference values.saving json to temp file (2)',
- stdout=api.raw_io.output('/tmp/dummy4')) +
api.override_step_data('device_status',
api.json.output(two_devices)) +
api.override_step_data('device_status (2)',
@@ -617,12 +605,6 @@ results-without_patch
parent_got_revision='1111111',
parent_build_archive_url='gs://test-domain/test-archive.zip') +
api.bisect_tester(tempfile='/tmp/dummy') +
- api.step_data(
- 'Gathering reference values.saving json to temp file',
- stdout=api.raw_io.output('/tmp/dummy3')) +
- api.step_data(
- 'Gathering reference values.saving json to temp file (2)',
- stdout=api.raw_io.output('/tmp/dummy4')) +
api.override_step_data('device_status',
api.json.output(working_device)) +
api.override_step_data('device_status (2)',
@@ -658,18 +640,6 @@ results-without_patch
parent_got_revision='1111111',
parent_build_archive_url='gs://test-domain/test-archive.zip') +
api.bisect_tester(tempfile='/tmp/dummy') +
- api.step_data(
- 'Gathering reference values.saving json to temp file',
- stdout=api.raw_io.output('/tmp/dummy3')) +
- api.step_data(
- 'Gathering reference values.saving json to temp file (2)',
- stdout=api.raw_io.output('/tmp/dummy4')) +
- api.step_data(
- 'Gathering reference values.saving json to temp file (3)',
- stdout=api.raw_io.output('/tmp/dummy5')) +
- api.step_data(
- 'Gathering reference values.saving json to temp file (4)',
- stdout=api.raw_io.output('/tmp/dummy6')) +
api.override_step_data('device_status',
api.json.output(two_devices)) +
api.override_step_data('device_status (2)',

Powered by Google App Engine
This is Rietveld 408576698