Refactor stages 1, 2 and test_api overhaul.

scripts/slave/recipes/bisection/android_bisect.py

 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from recipe_engine.types import freeze
 
 DEPS = [
     'auto_bisect',
     'bisect_tester',
     'depot_tools/bot_update',
@@ skipping 383 matching lines @@
           'bug_id': '425582',
           'gs_bucket': 'chrome-perf',
           'builder_host': 'master4.golo.chromium.org',
           'builder_port': '8341'
       }
       yield (api.test('basic_recipe_' + buildername) +
           api.properties.tryserver(
               path_config='kitchen',
               mastername='tryserver.chromium.perf',
               buildername=buildername) +
-          api.step_data(
-              'saving url to temp file',
-              stdout=api.raw_io.output('/tmp/dummy1')) +
-          api.step_data(
-              'saving json to temp file',
-              stdout=api.raw_io.output('/tmp/dummy2')) +
           api.properties(
                       bisect_config=bisect_config) + api.properties(
                           job_name='f7a7b4135624439cbd27fdd5133d74ec') +
              api.bisect_tester(tempfile='/tmp/dummy') +
              api.properties(parent_got_revision='1111111') + api.properties(
                  parent_build_archive_url='gs://test-domain/test-archive.zip'))
 
       local_bisect_config = {
           'test_type': 'perf',
           'command': './tools/perf/run_benchmark -v '
@@ skipping 136 matching lines @@
     api.properties.tryserver(
         mastername='tryserver.chromium.perf', buildername=buildername) +
     api.properties(
         path_config='kitchen',
         bisect_config=local_bisect_config,
         job_name='f7a7b4135624439cbd27fdd5133d74ec',
         local_test=True,
         parent_got_revision='1111111',
         parent_build_archive_url='gs://test-domain/test-archive.zip') +
     api.bisect_tester(tempfile='/tmp/dummy') +
-    api.step_data(
-        'Gathering reference values.saving json to temp file',
-        stdout=api.raw_io.output('/tmp/dummy3')) +
-    api.step_data(
-        'Gathering reference values.saving json to temp file (2)',
-        stdout=api.raw_io.output('/tmp/dummy4')) +
     api.override_step_data('device_status',
         api.json.output(two_devices)) +
     api.override_step_data('device_status (2)',
         api.json.output(two_devices)) +
     api.step_data('Resolving reference range.crrev get commit hash for ' +
         ('refs/heads/master@{#%s}' % local_bisect_config['bad_revision']),
         stdout=api.json.output(
             {'git_sha': bad_revision_hash}))+
     api.step_data('Resolving reference range.crrev get commit hash for ' +
         ('refs/heads/master@{#%s}' % local_bisect_config[
@@ skipping 28 matching lines @@
     api.properties.tryserver(
         mastername='tryserver.chromium.perf', buildername=buildername) +
     api.properties(
         path_config='kitchen',
         bisect_config=local_bisect_config,
         job_name='f7a7b4135624439cbd27fdd5133d74ec',
         local_test=True,
         parent_got_revision='1111111',
         parent_build_archive_url='gs://test-domain/test-archive.zip') +
     api.bisect_tester(tempfile='/tmp/dummy') +
-    api.step_data(
-        'Gathering reference values.saving json to temp file',
-        stdout=api.raw_io.output('/tmp/dummy3')) +
-    api.step_data(
-        'Gathering reference values.saving json to temp file (2)',
-        stdout=api.raw_io.output('/tmp/dummy4')) +
     api.override_step_data('device_status',
         api.json.output(working_device)) +
     api.override_step_data('device_status (2)',
         api.json.output(working_device)) +
     api.step_data('Resolving reference range.crrev get commit hash for ' +
         ('refs/heads/master@{#%s}' % local_bisect_config['bad_revision']),
         stdout=api.json.output(
             {'git_sha': bad_revision_hash}))+
     api.step_data('Resolving reference range.crrev get commit hash for ' +
         ('refs/heads/master@{#%s}' % local_bisect_config[
@@ skipping 15 matching lines @@
     api.properties.tryserver(
         mastername='tryserver.chromium.perf', buildername=buildername) +
     api.properties(
         path_config='kitchen',
         bisect_config=local_bisect_config,
         job_name='f7a7b4135624439cbd27fdd5133d74ec',
         local_test=True,
         parent_got_revision='1111111',
         parent_build_archive_url='gs://test-domain/test-archive.zip') +
     api.bisect_tester(tempfile='/tmp/dummy') +
-    api.step_data(
-        'Gathering reference values.saving json to temp file',
-        stdout=api.raw_io.output('/tmp/dummy3')) +
-    api.step_data(
-        'Gathering reference values.saving json to temp file (2)',
-        stdout=api.raw_io.output('/tmp/dummy4')) +
-    api.step_data(
-        'Gathering reference values.saving json to temp file (3)',
-        stdout=api.raw_io.output('/tmp/dummy5')) +
-    api.step_data(
-        'Gathering reference values.saving json to temp file (4)',
-        stdout=api.raw_io.output('/tmp/dummy6')) +
     api.override_step_data('device_status',
         api.json.output(two_devices)) +
     api.override_step_data('device_status (2)',
         api.json.output(two_devices)) +
     api.step_data('Resolving reference range.crrev get commit hash for ' +
         ('refs/heads/master@{#%s}' % local_bisect_config['bad_revision']),
         stdout=api.json.output(
             {'git_sha': bad_revision_hash}))+
     api.step_data('Resolving reference range.crrev get commit hash for ' +
         ('refs/heads/master@{#%s}' % local_bisect_config[
             'good_revision']),
         stdout=api.json.output(
             {'git_sha': good_revision_hash}))+
     api.step_data('Expanding revision range.for revisions %s:%s' % (
             good_revision_hash, bad_revision_hash),
         stdout=api.json.output([[bad_revision_hash, 'ignored'], [
             good_revision_hash, 'ignored']])) +
     # Simulating disconnect by raising failure and changing the output of
     # multiple_device_status
     api.step_data('Debug Info', retcode=1) +
     api.override_step_data('device_status (3)',
         api.json.output(working_device)) +
     api.step_data('Expanding revision range.for revisions %s:%s (2)' % (
             good_revision_hash, bad_revision_hash),
         stdout=api.json.output([[bad_revision_hash, 'ignored'], [
             good_revision_hash, 'ignored']])) +
     api.step_data('Post bisect results',
         stdout=api.json.output({'status_code': 200})))