third_party/closure_compiler/run_compiler - Issue 2247353004: GN files for running Closure Compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/run_compiler

Issue 2247353004: GN files for running Closure Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix some nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/closure_compiler/run_compiler

diff --git a/third_party/closure_compiler/run_compiler b/third_party/closure_compiler/run_compiler

index 884c41551c4f6a4583d86eeef1475b41c626af1c..b292233ea67bfd429d3ad8318db5224f2d12eeb5 100755

--- a/third_party/closure_compiler/run_compiler

+++ b/third_party/closure_compiler/run_compiler

@@ -14,3 +14,7 @@ third_party/closure_compiler/compiled_resources.gyp \

third_party/closure_compiler/compiled_resources2.gyp

ninja -C out/Default -j4 $@

+gn gen --args='root_extra_deps=["//third_party/closure_compiler:compile_js_all"]' out/Default

Dan Beam 2016/09/07 18:18:05 80 col wrap

Dan Beam 2016/09/07 18:18:05 nit: store "third_party/closure_compiler:compile_j

Dan Beam 2016/09/07 18:18:05 can we change the name of where these are generate

+ninja -C out/Default third_party/closure_compiler:compile_js_all