third_party/closure_compiler/run_compiler - Issue 2247353004: GN files for running Closure Compiler

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/closure_compiler/run_compiler

Issue 2247353004: GN files for running Closure Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix some nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #!/bin/sh	1 #!/bin/sh

2 # Copyright 2016 The Chromium Authors. All rights reserved.	2 # Copyright 2016 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 set -e	6 set -e

7	7

8 cd $(dirname "$0")/../..	8 cd $(dirname "$0")/../..

9	9

10 export GYP_GENERATORS="ninja"	10 export GYP_GENERATORS="ninja"

11	11

12 tools/gyp/gyp --no-circular-check \	12 tools/gyp/gyp --no-circular-check \

13 third_party/closure_compiler/compiled_resources.gyp \	13 third_party/closure_compiler/compiled_resources.gyp \

14 third_party/closure_compiler/compiled_resources2.gyp	14 third_party/closure_compiler/compiled_resources2.gyp

15	15

16 ninja -C out/Default -j4 $@	16 ninja -C out/Default -j4 $@

	17

	18 gn gen --args='root_extra_deps=["//third_party/closure_compiler:compile_js_all"] ' out/Default
	Dan Beam 2016/09/07 18:18:05 80 col wrap 80 col wrap Dan Beam 2016/09/07 18:18:05 nit: store "third_party/closure_compiler:compile_j nit: store "third_party/closure_compiler:compile_js_all" in variable and reuse it in both places, i.e. GN_ALL_TARGET="third_party/closure_compiler:compile_js_all" gn gen --args="root_extra_deps=[""//${GN_ALL_TARGET}""]" ninja -C closure_compilation/gn "${GN_ALL_TARGET}" Dan Beam 2016/09/07 18:18:05 can we change the name of where these are generate can we change the name of where these are generated to? i.e. gyp -Goutput_dir=closure_compilation ninja -C closure_compilation/Default gn gen --args='...' closure_compilation/gn ninja -C closure_compilation/gn
	19

	20 ninja -C out/Default third_party/closure_compiler:compile_js_all

OLD	NEW

« third_party/closure_compiler/compile_js2.gni ('K') | « third_party/closure_compiler/compile_js2.gni ('k') | third_party/jstemplate/BUILD.gn » ('j') | no next file with comments »