Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2247313002:
Reenable CaptureScreenshot test for mac/msan builds. (Closed)
|
Created:
4 years, 4 months ago by Eric Seckler Modified:
4 years, 4 months ago Reviewers:
dgozman CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, Sami Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReenables the CaptureScreenshot test for mac and msan builds. Also adds
checks for an additional pixel to help triage in case this regresses again.
BUG=430620, 423583
Committed: https://crrev.com/f415c1a3b0e19e221b0b94d31ed33e688cc8fc22
Cr-Commit-Position: refs/heads/master@{#412485}
Patch Set 1 #
Messages
Total messages: 28 (23 generated)
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== reenable CaptureScreenshot test, add checks for additional pixel. BUG= ========== to ========== Reenables the CaptureScreenshot test for mac and msan builds. Also adds checks for an additional pixel to help triage in case this regresses again. BUG=430620,423583 ==========
Description was changed from ========== Reenables the CaptureScreenshot test for mac and msan builds. Also adds checks for an additional pixel to help triage in case this regresses again. BUG=430620,423583 ========== to ========== Reenables the CaptureScreenshot test for mac and msan builds. Also adds checks for an additional pixel to help triage in case this regresses again. BUG=430620,423583 ==========
Patchset #1 (id:1) has been deleted
eseckler@chromium.org changed reviewers: + dgozman@chromium.org
Hi Dmitry, I'm trying to reproduce the bugs referenced in the description, but am not able to. Maybe the cause(s) were resolved? Does it make sense to re-enable the test and roll back in case it does regress? Thanks! Eric
Sure, let's try this. lgtm
The CQ bit was checked by eseckler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Reenables the CaptureScreenshot test for mac and msan builds. Also adds checks for an additional pixel to help triage in case this regresses again. BUG=430620,423583 ========== to ========== Reenables the CaptureScreenshot test for mac and msan builds. Also adds checks for an additional pixel to help triage in case this regresses again. BUG=430620,423583 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Reenables the CaptureScreenshot test for mac and msan builds. Also adds checks for an additional pixel to help triage in case this regresses again. BUG=430620,423583 ========== to ========== Reenables the CaptureScreenshot test for mac and msan builds. Also adds checks for an additional pixel to help triage in case this regresses again. BUG=430620,423583 Committed: https://crrev.com/f415c1a3b0e19e221b0b94d31ed33e688cc8fc22 Cr-Commit-Position: refs/heads/master@{#412485} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f415c1a3b0e19e221b0b94d31ed33e688cc8fc22 Cr-Commit-Position: refs/heads/master@{#412485} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
