Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2247313002: Reenable CaptureScreenshot test for mac/msan builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index 0c577b651df47ac9e6df319f0b71e1cd4f610cc1..963bc7a843fe15273ba1ecd48fa12454b3d0b3b6 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -377,17 +377,8 @@ class CaptureScreenshotTest : public DevToolsProtocolTest {
};
// Does not link on Android
-#if defined(OS_ANDROID)
-#define MAYBE_CaptureScreenshot DISABLED_CaptureScreenshot
-#elif defined(OS_MACOSX) // Fails on 10.9. http://crbug.com/430620
-#define MAYBE_CaptureScreenshot DISABLED_CaptureScreenshot
-#elif defined(MEMORY_SANITIZER)
-// Also fails under MSAN. http://crbug.com/423583
-#define MAYBE_CaptureScreenshot DISABLED_CaptureScreenshot
-#else
-#define MAYBE_CaptureScreenshot CaptureScreenshot
-#endif
-IN_PROC_BROWSER_TEST_F(CaptureScreenshotTest, MAYBE_CaptureScreenshot) {
+#if !defined(OS_ANDROID)
+IN_PROC_BROWSER_TEST_F(CaptureScreenshotTest, CaptureScreenshot) {
shell()->LoadURL(GURL("about:blank"));
Attach();
EXPECT_TRUE(content::ExecuteScript(
@@ -402,10 +393,15 @@ IN_PROC_BROWSER_TEST_F(CaptureScreenshotTest, MAYBE_CaptureScreenshot) {
gfx::PNGCodec::Decode(reinterpret_cast<const unsigned char*>(png.data()),
png.size(), &bitmap);
SkColor color(bitmap.getColor(0, 0));
- EXPECT_TRUE(std::abs(0x12-(int)SkColorGetR(color)) <= 1);
- EXPECT_TRUE(std::abs(0x34-(int)SkColorGetG(color)) <= 1);
- EXPECT_TRUE(std::abs(0x56-(int)SkColorGetB(color)) <= 1);
+ EXPECT_GE(1, std::abs(0x12-(int)SkColorGetR(color)));
+ EXPECT_GE(1, std::abs(0x34-(int)SkColorGetG(color)));
+ EXPECT_GE(1, std::abs(0x56-(int)SkColorGetB(color)));
+ color = bitmap.getColor(1, 1);
+ EXPECT_GE(1, std::abs(0x12-(int)SkColorGetR(color)));
+ EXPECT_GE(1, std::abs(0x34-(int)SkColorGetG(color)));
+ EXPECT_GE(1, std::abs(0x56-(int)SkColorGetB(color)));
}
+#endif
#if defined(OS_ANDROID)
// Disabled, see http://crbug.com/469947.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698