Prevent formatting a device being mounted in read-only mode.

Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount-for-format
operation to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy after
https://codereview.chromium.org/2230713003/ ,
in addition to HW write-protected device.

The UI issue (crbug.com/636373) will also be fixed separately.

TEST=unittest and manual test utilizing the repro steps noted in crbug.com/636373 to see formatting a writable device results in an error. The manual test requires to merge 2230713003 and 2248033003 locally.
BUG=629945, 636373
Committed: https://crrev.com/bffc32eb63e5e211a1f2bd44cae8c91bc5ac2922
Cr-Commit-Position: refs/heads/master@{#412461}

[yamaguchi, 2016-08-16 08:20:53]

Description was changed from

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount and format
operations to ensure that the read-only devices cannot be formatted even
when the UI issues that command. The UI issue (crbug.com/636373) will
also be fixed separately.

BUG=636373
==========

to

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount and format
operations to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy (in
addition to HW write-protected device) after
https://codereview.chromium.org/2230713003/ .

The UI issue (crbug.com/636373) will also be fixed separately.

BUG=629945,636373
==========

[yamaguchi, 2016-08-16 08:22:48]

Description was changed from

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount and format
operations to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy (in
addition to HW write-protected device) after
https://codereview.chromium.org/2230713003/ .

The UI issue (crbug.com/636373) will also be fixed separately.

BUG=629945,636373
==========

to

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount-for-format
operation to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy after
https://codereview.chromium.org/2230713003/ ,
in addition to HW write-protected device.

The UI issue (crbug.com/636373) will also be fixed separately.

BUG=629945,636373
==========

[yamaguchi, 2016-08-16 08:34:15]

yamaguchi@chromium.org changed reviewers:
+ satorux@chromium.org

[satorux1, 2016-08-16 20:24:04]

Please also add TEST= line in the description that describes how you tested the
change.

https://codereview.chromium.org/2247263002/diff/20001/chromeos/disks/disk_mou...
File chromeos/disks/disk_mount_manager_unittest.cc (right):

https://codereview.chromium.org/2247263002/diff/20001/chromeos/disks/disk_mou...
chromeos/disks/disk_mount_manager_unittest.cc:63: {
Is this indentation change necessary? Maybe done by clang-format?

If it's by accident, please change it back.

[yamaguchi, 2016-08-17 04:06:17]

https://codereview.chromium.org/2247263002/diff/20001/chromeos/disks/disk_mou...
File chromeos/disks/disk_mount_manager_unittest.cc (right):

https://codereview.chromium.org/2247263002/diff/20001/chromeos/disks/disk_mou...
chromeos/disks/disk_mount_manager_unittest.cc:63: {
On 2016/08/16 20:24:04, satorux1 wrote:
> Is this indentation change necessary? Maybe done by clang-format?
> 
> If it's by accident, please change it back.

It was done by clang-format.
Reverted some changes to make this CL clearer.

[yamaguchi, 2016-08-17 05:03:58]

Description was changed from

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount-for-format
operation to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy after
https://codereview.chromium.org/2230713003/ ,
in addition to HW write-protected device.

The UI issue (crbug.com/636373) will also be fixed separately.

BUG=629945,636373
==========

to

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount-for-format
operation to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy after
https://codereview.chromium.org/2230713003/ ,
in addition to HW write-protected device.

The UI issue (crbug.com/636373) will also be fixed separately.

TEST=unittest
BUG=629945,636373
==========

[satorux1, 2016-08-17 05:15:03]

LGTM.

Re testing, did you also test this manually? Please also mention it in TEST=
line.

[yamaguchi, 2016-08-17 05:48:11]

Description was changed from

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount-for-format
operation to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy after
https://codereview.chromium.org/2230713003/ ,
in addition to HW write-protected device.

The UI issue (crbug.com/636373) will also be fixed separately.

TEST=unittest
BUG=629945,636373
==========

to

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount-for-format
operation to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy after
https://codereview.chromium.org/2230713003/ ,
in addition to HW write-protected device.

The UI issue (crbug.com/636373) will also be fixed separately.

TEST=unittest and manual test utilizing the repro steps noted in Issue 636373 to
see formatting a writable device results in an error. The manual test requires
to merge 2230713003 and 2248033003 locally.
BUG=629945,636373
==========

[yamaguchi, 2016-08-17 05:48:39]

Description was changed from

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount-for-format
operation to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy after
https://codereview.chromium.org/2230713003/ ,
in addition to HW write-protected device.

The UI issue (crbug.com/636373) will also be fixed separately.

TEST=unittest and manual test utilizing the repro steps noted in Issue 636373 to
see formatting a writable device results in an error. The manual test requires
to merge 2230713003 and 2248033003 locally.
BUG=629945,636373
==========

to

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount-for-format
operation to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy after
https://codereview.chromium.org/2230713003/ ,
in addition to HW write-protected device.

The UI issue (crbug.com/636373) will also be fixed separately.

TEST=unittest and manual test utilizing the repro steps noted in
crbug.com/636373 to see formatting a writable device results in an error. The
manual test requires to merge 2230713003 and 2248033003 locally.
BUG=629945,636373
==========

[yamaguchi, 2016-08-17 05:53:41]

On 2016/08/17 05:15:03, satorux1 wrote:
> LGTM.
> 
> Re testing, did you also test this manually? Please also mention it in TEST=
> line.

Done.

[yamaguchi, 2016-08-17 05:54:07]

The CQ bit was checked by yamaguchi@chromium.org

[commit-bot: I haz the power, 2016-08-17 05:54:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 06:36:04]

Description was changed from

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount-for-format
operation to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy after
https://codereview.chromium.org/2230713003/ ,
in addition to HW write-protected device.

The UI issue (crbug.com/636373) will also be fixed separately.

TEST=unittest and manual test utilizing the repro steps noted in
crbug.com/636373 to see formatting a writable device results in an error. The
manual test requires to merge 2230713003 and 2248033003 locally.
BUG=629945,636373
==========

to

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount-for-format
operation to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy after
https://codereview.chromium.org/2230713003/ ,
in addition to HW write-protected device.

The UI issue (crbug.com/636373) will also be fixed separately.

TEST=unittest and manual test utilizing the repro steps noted in
crbug.com/636373 to see formatting a writable device results in an error. The
manual test requires to merge 2230713003 and 2248033003 locally.
BUG=629945,636373
==========

[commit-bot: I haz the power, 2016-08-17 06:36:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-17 06:37:53]

Description was changed from

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount-for-format
operation to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy after
https://codereview.chromium.org/2230713003/ ,
in addition to HW write-protected device.

The UI issue (crbug.com/636373) will also be fixed separately.

TEST=unittest and manual test utilizing the repro steps noted in
crbug.com/636373 to see formatting a writable device results in an error. The
manual test requires to merge 2230713003 and 2248033003 locally.
BUG=629945,636373
==========

to

==========
Prevent formatting a device being mounted in read-only mode.
The change adds a double check before starting unmount-for-format
operation to ensure that the read-only devices cannot be formatted even
when the UI issues that command.
It will also apply for devices mounted in read-only mode by the policy after
https://codereview.chromium.org/2230713003/ ,
in addition to HW write-protected device.

The UI issue (crbug.com/636373) will also be fixed separately.

TEST=unittest and manual test utilizing the repro steps noted in
crbug.com/636373 to see formatting a writable device results in an error. The
manual test requires to merge 2230713003 and 2248033003 locally.
BUG=629945,636373

Committed: https://crrev.com/bffc32eb63e5e211a1f2bd44cae8c91bc5ac2922
Cr-Commit-Position: refs/heads/master@{#412461}
==========

[commit-bot: I haz the power, 2016-08-17 06:37:54]

Patchset 4 (id:??) landed as
https://crrev.com/bffc32eb63e5e211a1f2bd44cae8c91bc5ac2922
Cr-Commit-Position: refs/heads/master@{#412461}