Prevent formatting a device being mounted in read-only mode.

chromeos/disks/disk_mount_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/fake_cros_disks_client.h"
 #include "chromeos/disks/disk_mount_manager.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using chromeos::disks::DiskMountManager;
 using chromeos::CrosDisksClient;
 using chromeos::DBusThreadManager;
 using chromeos::FakeCrosDisksClient;
 using testing::_;
 using testing::Field;
 using testing::InSequence;
 
 namespace {
 
+const char kReadOnlyMountpath[] = "/device/read_only_mount_path";
+const char kReadOnlyDeviceSource[] = "/device/read_only_source_path";
+
 // Holds information needed to create a DiskMountManager::Disk instance.
 struct TestDiskInfo {
   const char* source_path;
   const char* mount_path;
   const char* system_path;
   const char* file_path;
   const char* device_label;
   const char* drive_label;
   const char* vendor_id;
   const char* vendor_name;
@@ skipping 14 matching lines @@
 // Holds information to create a DiskMOuntManager::MountPointInfo instance.
 struct TestMountPointInfo {
   const char* source_path;
   const char* mount_path;
   chromeos::MountType mount_type;
   chromeos::disks::MountCondition mount_condition;
 };
 
 // List of disks held in DiskMountManager at the begining of the test.
 const TestDiskInfo kTestDisks[] = {
-  {
-    "/device/source_path",
-    "/device/mount_path",
-    "/device/prefix/system_path",
-    "/device/file_path",
-    "/device/device_label",
-    "/device/drive_label",
-    "/device/vendor_id",
-    "/device/vendor_name",
-    "/device/product_id",
-    "/device/product_name",
-    "/device/fs_uuid",
-    "/device/prefix",
-    chromeos::DEVICE_TYPE_USB,
-    1073741824,  // size in bytes
-    false,  // is parent
-    false,  // is read only
-    true,  // has media
-    false,  // is on boot device
-    true,  // is on removable device
-    false  // is hidden
-  },
+    {

[satorux1, 2016/08/16 20:24:04]

Is this indentation change necessary? Maybe done by clang-format?

If it's by accident, please change it back.

[yamaguchi, 2016/08/17 04:06:17]

It was done by clang-format.
Reverted some changes to make this CL clearer.

+        "/device/source_path",
+        "/device/mount_path",
+        "/device/prefix/system_path",
+        "/device/file_path",
+        "/device/device_label",
+        "/device/drive_label",
+        "/device/vendor_id",
+        "/device/vendor_name",
+        "/device/product_id",
+        "/device/product_name",
+        "/device/fs_uuid",
+        "/device/prefix",
+        chromeos::DEVICE_TYPE_USB,
+        1073741824,  // size in bytes
+        false,       // is parent
+        false,       // is read only
+        true,        // has media
+        false,       // is on boot device
+        true,        // is on removable device
+        false        // is hidden
+    },
+    {
+        kReadOnlyDeviceSource,
+        kReadOnlyMountpath,
+        "/device/prefix/system_path_2",
+        "/device/file_path_2",
+        "/device/device_label_2",
+        "/device/drive_label_2",
+        "/device/vendor_id_2",
+        "/device/vendor_name_2",
+        "/device/product_id_2",
+        "/device/product_name_2",
+        "/device/fs_uuid_2",
+        "/device/prefix",
+        chromeos::DEVICE_TYPE_USB,
+        1073741824,  // size in bytes
+        false,       // is parent
+        true,        // is read only
+        true,        // has media
+        false,       // is on boot device
+        true,        // is on removable device
+        false        // is hidden
+    },
 };
 
 // List of mount points  held in DiskMountManager at the begining of the test.
 const TestMountPointInfo kTestMountPoints[] = {
-  {
-    "/archive/source_path",
-    "/archive/mount_path",
-    chromeos::MOUNT_TYPE_ARCHIVE,
-    chromeos::disks::MOUNT_CONDITION_NONE
-  },
-  {
-    "/device/source_path",
-    "/device/mount_path",
-    chromeos::MOUNT_TYPE_DEVICE,
-    chromeos::disks::MOUNT_CONDITION_NONE
-  },
+    {
+        "/archive/source_path",
+        "/archive/mount_path",
+        chromeos::MOUNT_TYPE_ARCHIVE,
+        chromeos::disks::MOUNT_CONDITION_NONE
+    },
+    {
+        "/device/source_path",
+        "/device/mount_path",
+        chromeos::MOUNT_TYPE_DEVICE,
+        chromeos::disks::MOUNT_CONDITION_NONE
+    },
+    {
+        kReadOnlyDeviceSource,
+        kReadOnlyMountpath,
+        chromeos::MOUNT_TYPE_DEVICE,
+        chromeos::disks::MOUNT_CONDITION_NONE
+    },
 };
 
 // Mocks DiskMountManager observer.
 class MockDiskMountManagerObserver : public DiskMountManager::Observer {
  public:
   virtual ~MockDiskMountManagerObserver() {}
 
   MOCK_METHOD2(OnDiskEvent, void(DiskMountManager::DiskEvent event,
                                  const DiskMountManager::Disk* disk));
   MOCK_METHOD2(OnDeviceEvent, void(DiskMountManager::DeviceEvent event,
@@ skipping 101 matching lines @@
 // Tests that the observer gets notified on attempt to format non existent mount
 // point.
 TEST_F(DiskMountManagerTest, Format_NotMounted) {
   EXPECT_CALL(observer_, OnFormatEvent(DiskMountManager::FORMAT_COMPLETED,
                                        chromeos::FORMAT_ERROR_UNKNOWN,
                                        "/mount/non_existent"))
       .Times(1);
   DiskMountManager::GetInstance()->FormatMountedDevice("/mount/non_existent");
 }
 
+// Tests that the observer gets notified on attempt to format read-only mount
+// point.
+TEST_F(DiskMountManagerTest, Format_ReadOnly) {
+  EXPECT_CALL(observer_,
+              OnFormatEvent(DiskMountManager::FORMAT_COMPLETED,
+                            chromeos::FORMAT_ERROR_DEVICE_NOT_ALLOWED,
+                            kReadOnlyMountpath))
+      .Times(1);
+  DiskMountManager::GetInstance()->FormatMountedDevice(kReadOnlyMountpath);
+}
+
 // Tests that it is not possible to format archive mount point.
 TEST_F(DiskMountManagerTest, Format_Archive) {
   EXPECT_CALL(observer_, OnFormatEvent(DiskMountManager::FORMAT_COMPLETED,
                                        chromeos::FORMAT_ERROR_UNKNOWN,
                                        "/archive/source_path"))
       .Times(1);
 
   DiskMountManager::GetInstance()->FormatMountedDevice("/archive/mount_path");
 }
 
@@ skipping 343 matching lines @@
   EXPECT_EQ("/device/source_path",
             fake_cros_disks_client_->last_format_device_path());
   EXPECT_EQ("vfat", fake_cros_disks_client_->last_format_filesystem());
 
   // Simulate cros_disks reporting success.
   fake_cros_disks_client_->SendFormatCompletedEvent(
       chromeos::FORMAT_ERROR_NONE, "/device/source_path");
 }
 
 }  // namespace