Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 224723025: Componentize TranslateManager (Closed)

Created:
6 years, 8 months ago by blundell
Modified:
6 years, 8 months ago
Reviewers:
droger, Nico
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Componentize TranslateManager This CL does the following: - Abstracts the loading of the translation detection error report URL in a new tab to go through the client - Removes knowledge of TranslateTabHelper from TranslateManager - Componentizes TranslateManager BUG=335078, 360020 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262676

Patch Set 1 #

Patch Set 2 : Nits #

Total comments: 2

Patch Set 3 : Response to review #

Patch Set 4 : Rebase #

Patch Set 5 : Fix Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -570 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/translate/translate_manager.h View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/translate/translate_manager.cc View 1 chunk +0 lines, -402 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_render_view_host_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_tab_helper.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/translate/translate_tab_helper.cc View 1 2 3 4 4 chunks +22 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_ui_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M components/translate.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_client.h View 1 chunk +5 lines, -0 lines 0 comments Download
A + components/translate/core/browser/translate_manager.h View 5 chunks +8 lines, -14 lines 0 comments Download
A + components/translate/core/browser/translate_manager.cc View 8 chunks +9 lines, -25 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
blundell
Dependent on https://codereview.chromium.org/228483003/
6 years, 8 months ago (2014-04-08 14:00:54 UTC) #1
droger
LGTM this is great! https://codereview.chromium.org/224723025/diff/20001/chrome/browser/translate/translate_tab_helper.h File chrome/browser/translate/translate_tab_helper.h (right): https://codereview.chromium.org/224723025/diff/20001/chrome/browser/translate/translate_tab_helper.h#newcode98 chrome/browser/translate/translate_tab_helper.h:98: OVERRIDE; Nit: do not break ...
6 years, 8 months ago (2014-04-08 14:10:54 UTC) #2
blundell
https://codereview.chromium.org/224723025/diff/20001/chrome/browser/translate/translate_tab_helper.h File chrome/browser/translate/translate_tab_helper.h (right): https://codereview.chromium.org/224723025/diff/20001/chrome/browser/translate/translate_tab_helper.h#newcode98 chrome/browser/translate/translate_tab_helper.h:98: OVERRIDE; On 2014/04/08 14:10:55, droger wrote: > Nit: do ...
6 years, 8 months ago (2014-04-08 20:01:52 UTC) #3
blundell
TBR=thakis for //chrome changes outside of //chrome/browser/translate
6 years, 8 months ago (2014-04-09 08:39:54 UTC) #4
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 8 months ago (2014-04-09 08:39:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/224723025/100001
6 years, 8 months ago (2014-04-09 08:40:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/224723025/100001
6 years, 8 months ago (2014-04-09 09:11:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/224723025/100001
6 years, 8 months ago (2014-04-09 09:18:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/224723025/100001
6 years, 8 months ago (2014-04-09 09:26:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/224723025/100001
6 years, 8 months ago (2014-04-09 09:33:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/224723025/100001
6 years, 8 months ago (2014-04-09 09:46:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/224723025/100001
6 years, 8 months ago (2014-04-09 09:55:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/224723025/100001
6 years, 8 months ago (2014-04-09 11:16:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/224723025/100001
6 years, 8 months ago (2014-04-09 11:26:17 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 13:00:28 UTC) #15
Message was sent while issue was closed. 
Change committed as 262676

Powered by Google App Engine
This is Rietveld 408576698