blimp/client/app/android/javatests/src/org/chromium/blimp/BlimpNativeInstrumentationTestCase.java - Issue 2247143004: Remove app context init from LibraryLoader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/app/android/javatests/src/org/chromium/blimp/BlimpNativeInstrumentationTestCase.java

Issue 2247143004: Remove app context init from LibraryLoader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix per review. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/app/android/javatests/src/org/chromium/blimp/BlimpNativeInstrumentationTestCase.java

diff --git a/blimp/client/app/android/javatests/src/org/chromium/blimp/BlimpNativeInstrumentationTestCase.java b/blimp/client/app/android/javatests/src/org/chromium/blimp/BlimpNativeInstrumentationTestCase.java

index 179138e52bbd0cf98b66653c00211616082f17fb..5a9e49921f185dd26fb6b1d9efc4466b25d203ad 100644

--- a/blimp/client/app/android/javatests/src/org/chromium/blimp/BlimpNativeInstrumentationTestCase.java

+++ b/blimp/client/app/android/javatests/src/org/chromium/blimp/BlimpNativeInstrumentationTestCase.java

@@ -25,13 +25,13 @@ public class BlimpNativeInstrumentationTestCase extends InstrumentationTestCase

@Override

public void run() {

try {

- BlimpLibraryLoader.startAsync(getInstrumentation().getTargetContext(),

- new BlimpLibraryLoader.Callback() {

- public void onStartupComplete(boolean success) {

- mSuccess = success;

- mNativeReadySemaphore.release();

- }

- });

+ BlimpLibraryLoader.startAsync(new BlimpLibraryLoader.Callback() {

+ @Override

+ public void onStartupComplete(boolean success) {

+ mSuccess = success;

+ mNativeReadySemaphore.release();

+ }

+ });

} catch (ProcessInitException e) {

throw new RuntimeException("Failed to initialize process.");

}