blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java - Issue 2247143004: Remove app context init from LibraryLoader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java

Issue 2247143004: Remove app context init from LibraryLoader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix per review. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java ('k') | blimp/client/app/android/javatests/src/org/chromium/blimp/BlimpNativeInstrumentationTestCase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java

diff --git a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java

index ddee170d7a77aa4c22e006b907a28d959b3f32ad..e07b93a4291ac0f48f6fc6368f15104522c58dd4 100644

--- a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java

+++ b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java

@@ -74,11 +74,9 @@ public class BlimpRendererActivity

@SuppressFBWarnings("DM_EXIT") // FindBugs doesn't like System.exit().

protected void onCreate(Bundle savedInstanceState) {

super.onCreate(savedInstanceState);

buildAndTriggerTokenSourceIfNeeded();

try {

- BlimpLibraryLoader.startAsync(this, this);

+ BlimpLibraryLoader.startAsync(this);

} catch (ProcessInitException e) {

Log.e(TAG, "Native startup exception", e);

System.exit(-1);