Issue 2247083002: Merge to M53: Fix issue when firing TimerProc() destroys timer

Issue 2247083002: Merge to M53: Fix issue when firing TimerProc() destroys timer (Closed)

Created:
4 years, 4 months ago by Oliver Chang

Modified:
4 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@2785

Target Ref:
refs/heads/chromium/2785

Project:
pdfium

Visibility:
Public.

Merge to M53: Fix issue when firing TimerProc() destroys timer We must look the timer up a second time since the callback may have released it. BUG=634394 TBR=thestig@chromium.org Original Review-Url: https://codereview.chromium.org/2214003003 (cherry picked from commit 32e693fe13105fab5baf81b334e932fce62d89b5) Committed: https://pdfium.googlesource.com/pdfium/+/3cde1a2d144e562b8bf3c8009039ca1cf67a8b44

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -17 lines)			Patch
M	fpdfsdk/fpdfformfill_embeddertest.cpp	View	1 chunk	+41 lines, -0 lines	0 comments	Download
M	fpdfsdk/javascript/JS_Object.cpp	View	1 chunk	+19 lines, -10 lines	0 comments	Download
A +	testing/resources/bug_634394.in	View	1 chunk	+8 lines, -3 lines	0 comments	Download
A +	testing/resources/bug_634394.pdf	View	2 chunks	+9 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

Oliver Chang

Committed patchset #1 (id:1) manually as 3cde1a2d144e562b8bf3c8009039ca1cf67a8b44 (presubmit successful).

4 years, 4 months ago (2016-08-15 21:28:24 UTC) #3

Message was sent while issue was closed.

lgtm