Fix issue when firing TimerProc() destroys timer

Fix issue when firing TimerProc() destroys timer

We must look the timer up a second time since the callback
may have released it.

BUG=634394
Committed: https://pdfium.googlesource.com/pdfium/+/32e693fe13105fab5baf81b334e932fce62d89b5

[Tom Sepez, 2016-08-04 18:32:31]

Description was changed from

==========
Fix issue when firing TimerProc() destroys timer
==========

to

==========
Fix issue when firing TimerProc() destroys timer

We must look the timer up a second time since the callback
may have released it,

BUG=634394
==========

[Tom Sepez, 2016-08-04 18:32:31]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-08-04 18:32:40]

Description was changed from

==========
Fix issue when firing TimerProc() destroys timer

We must look the timer up a second time since the callback
may have released it,

BUG=634394
==========

to

==========
Fix issue when firing TimerProc() destroys timer

We must look the timer up a second time since the callback
may have released it.

BUG=634394
==========

[Tom Sepez, 2016-08-04 18:33:10]

Lei, for review.  The thought of this crossed my mind while fixing the other
bug.

[Lei Zhang, 2016-08-04 19:02:40]

https://codereview.chromium.org/2214003003/diff/1/fpdfsdk/javascript/JS_Objec...
File fpdfsdk/javascript/JS_Object.cpp (right):

https://codereview.chromium.org/2214003003/diff/1/fpdfsdk/javascript/JS_Objec...
fpdfsdk/javascript/JS_Object.cpp:130: // Timer proc may have destroyed timer,
find it again.
Is it possible for a new timer with the same |idEvent| to get set from running
the timer proc, thus destroying |pTimer|, but putting a new timer into the same
slot in the map?

[Tom Sepez, 2016-08-04 19:12:40]

https://codereview.chromium.org/2214003003/diff/1/fpdfsdk/javascript/JS_Objec...
File fpdfsdk/javascript/JS_Object.cpp (right):

https://codereview.chromium.org/2214003003/diff/1/fpdfsdk/javascript/JS_Objec...
fpdfsdk/javascript/JS_Object.cpp:130: // Timer proc may have destroyed timer,
find it again.
On 2016/08/04 19:02:40, Lei Zhang wrote:
> Is it possible for a new timer with the same |idEvent| to get set from running
> the timer proc, thus destroying |pTimer|, but putting a new timer into the
same
> slot in the map?

It's up to the embedder, and doesn't happen AFAICT with our various embedders,
but doesn't hurt to check.  Other things probably go off the rails if they are
reused ...

[Lei Zhang, 2016-08-04 19:19:47]

lgtm

[Tom Sepez, 2016-08-04 19:21:41]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-08-04 19:21:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-04 19:23:56]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[Tom Sepez, 2016-08-04 19:26:01]

The CQ bit was unchecked by tsepez@chromium.org

[Tom Sepez, 2016-08-04 19:26:02]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-08-04 19:26:02]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2214003003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-04 19:26:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 19:47:44]

Description was changed from

==========
Fix issue when firing TimerProc() destroys timer

We must look the timer up a second time since the callback
may have released it.

BUG=634394
==========

to

==========
Fix issue when firing TimerProc() destroys timer

We must look the timer up a second time since the callback
may have released it.

BUG=634394

Committed:
https://pdfium.googlesource.com/pdfium/+/32e693fe13105fab5baf81b334e932fce62d...
==========

[commit-bot: I haz the power, 2016-08-04 19:47:45]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/32e693fe13105fab5baf81b334e932fce62d...