Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2247073007: Make SharedBuffer in Resource non-discardable and remove PurgeableVector (Closed)

Created:
4 years, 4 months ago by hiroshige
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@SharedBuffer_DoNotUnlock
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SharedBuffer in Resource non-discardable and remove PurgeableVector This CL makes SharedBuffer in Resource non-discardable (i.e. replaces SharedBuffer::createPurgeable() with SharedBuffer::create()), as we no longer have SharedBuffer::lock()/unlock() after https://codereview.chromium.org/2253853002/. After that, all SharedBuffers are non-purgeable, and thus this CL makes SharedBuffer always non-purgeable by replacing PurgeableVector in SharedBuffer with WTF::Vector. BUG=603791 Committed: https://crrev.com/8fd341495e433ab7042c60cf0f099551ef249e7b Cr-Commit-Position: refs/heads/master@{#415568}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -608 lines) Patch
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/platform/PurgeableVector.h View 1 3 4 1 chunk +0 lines, -114 lines 0 comments Download
D third_party/WebKit/Source/platform/PurgeableVector.cpp View 1 3 4 1 chunk +0 lines, -229 lines 0 comments Download
D third_party/WebKit/Source/platform/PurgeableVectorTest.cpp View 1 3 4 1 chunk +0 lines, -215 lines 0 comments Download
M third_party/WebKit/Source/platform/SharedBuffer.h View 1 3 4 4 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/SharedBuffer.cpp View 1 2 3 4 4 chunks +6 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/SharedBufferTest.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 3 4 5 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
hiroshige
haraken@, bashi@, PTAL. yhirano@ and japhet@, FYI.
4 years, 4 months ago (2016-08-17 07:57:54 UTC) #4
hiroshige
On 2016/08/17 07:57:54, hiroshige wrote: > haraken@, bashi@, PTAL. > yhirano@ and japhet@, FYI. For ...
4 years, 4 months ago (2016-08-17 07:59:30 UTC) #5
haraken
LGTM on my side.
4 years, 4 months ago (2016-08-17 08:05:38 UTC) #6
bashi
lgtm!
4 years, 4 months ago (2016-08-17 23:42:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247073007/90001
4 years, 3 months ago (2016-08-31 05:33:31 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years, 3 months ago (2016-08-31 05:37:53 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 05:40:10 UTC) #20
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8fd341495e433ab7042c60cf0f099551ef249e7b
Cr-Commit-Position: refs/heads/master@{#415568}

Powered by Google App Engine
This is Rietveld 408576698