Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: third_party/WebKit/Source/platform/SharedBuffer.h

Issue 2247073007: Make SharedBuffer in Resource non-discardable and remove PurgeableVector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SharedBuffer_DoNotUnlock
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/SharedBuffer.h
diff --git a/third_party/WebKit/Source/platform/SharedBuffer.h b/third_party/WebKit/Source/platform/SharedBuffer.h
index 99671ebd6653b6e181ca2fb5302331526efb28ae..7082c6a2b7e8c9e6dd4d590553accbe0d21b2dfc 100644
--- a/third_party/WebKit/Source/platform/SharedBuffer.h
+++ b/third_party/WebKit/Source/platform/SharedBuffer.h
@@ -28,10 +28,10 @@
#define SharedBuffer_h
#include "platform/PlatformExport.h"
-#include "platform/PurgeableVector.h"
#include "third_party/skia/include/core/SkData.h"
#include "wtf/Forward.h"
#include "wtf/RefCounted.h"
+#include "wtf/Vector.h"
#include "wtf/text/WTFString.h"
namespace blink {
@@ -65,13 +65,6 @@ public:
return adoptRef(new SharedBuffer(data, size));
}
- HAS_STRICTLY_TYPED_ARG
- static PassRefPtr<SharedBuffer> createPurgeable(const char* data, STRICTLY_TYPED_ARG(size))
- {
- STRICT_ARG_TYPE(size_t);
- return adoptRef(new SharedBuffer(data, size, PurgeableVector::Purgeable));
- }
-
static PassRefPtr<SharedBuffer> adoptVector(Vector<char>&);
~SharedBuffer();
@@ -152,7 +145,6 @@ private:
explicit SharedBuffer(size_t);
SharedBuffer(const char*, size_t);
SharedBuffer(const unsigned char*, size_t);
- SharedBuffer(const char*, size_t, PurgeableVector::PurgeableOption);
// See SharedBuffer::data().
void mergeSegmentsIntoBuffer() const;
@@ -162,7 +154,7 @@ private:
size_t getSomeDataInternal(const char*& data, size_t position) const;
size_t m_size;
- mutable PurgeableVector m_buffer;
+ mutable Vector<char> m_buffer;
mutable Vector<char*> m_segments;
};
« no previous file with comments | « third_party/WebKit/Source/platform/PurgeableVectorTest.cpp ('k') | third_party/WebKit/Source/platform/SharedBuffer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698