Issue 2247073003: Reorder DCHECKs so !is_with_scope() has a chance of being useful

Issue 2247073003: Reorder DCHECKs so !is_with_scope() has a chance of being useful (Closed)

Created:
4 years, 4 months ago by Toon Verwaest

Modified:
4 years, 4 months ago

Reviewers:
marja

CC:
v8-reviews_googlegroups.com, adamk

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Reorder DCHECKs so !is_with_scope() has a chance of being useful BUG=v8:5209 Committed: https://crrev.com/7a2553ff871b5825810081dd30f9b0abbd6e8eef Cr-Commit-Position: refs/heads/master@{#38646}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/ast/scopes.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (3 generated)

marja

lgtm (you concluded w/ adamk@ that you still want both dchecks, right?)

4 years, 4 months ago (2016-08-16 08:56:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247073003/1

4 years, 4 months ago (2016-08-16 09:03:36 UTC) #5

Toon Verwaest

Indeed. He just wanted me to reorder them, which is what I'm doing here.

4 years, 4 months ago (2016-08-16 09:03:44 UTC) #6

commit-bot: I haz the power

4 years, 4 months ago (2016-08-16 09:30:13 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7a2553ff871b5825810081dd30f9b0abbd6e8eef
Cr-Commit-Position: refs/heads/master@{#38646}