Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: src/ast/scopes.cc

Issue 2247073003: Reorder DCHECKs so !is_with_scope() has a chance of being useful (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.cc
diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc
index 28d405873a6e1b6640302bdcbf6659e9b078aeae..ea9fc9c8d51d4367e616c9f6e5e7f3e784abf2fe 100644
--- a/src/ast/scopes.cc
+++ b/src/ast/scopes.cc
@@ -1306,8 +1306,8 @@ Variable* Scope::LookupRecursive(VariableProxy* proxy,
return nullptr;
}
} else {
- DCHECK(is_function_scope() || is_script_scope() || is_eval_scope());
DCHECK(!is_with_scope());
+ DCHECK(is_function_scope() || is_script_scope() || is_eval_scope());
}
if (calls_sloppy_eval() && is_declaration_scope() && !is_script_scope()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698