Issue 2246963002: [isolate] Remove unused exception handle

Issue 2246963002: [isolate] Remove unused exception handle (Closed)

Created:
4 years, 4 months ago by gsathya

Modified:
4 years, 4 months ago

Reviewers:
adamk

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[isolate] Remove unused exception handle Committed: https://crrev.com/0f40fb207d7a30ce283f18b37fb5674afb6c7580 Cr-Commit-Position: refs/heads/master@{#38639}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -5 lines)			Patch
M	src/contexts.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/isolate.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.cc	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
A	src/js/microtaskq.js	View	1	1 chunk	+45 lines, -0 lines	0 comments	Download
M	src/js/prologue.js	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/js/promise.js	View	1	4 chunks	+4 lines, -2 lines	0 comments	Download
M	src/v8.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 14 (9 generated)

adamk

lgtm To be pedantic, it's an unused Handle, not an Object :)

4 years, 4 months ago (2016-08-15 18:15:06 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246963002/1

4 years, 4 months ago (2016-08-15 18:16:32 UTC) #11

commit-bot: I haz the power

4 years, 4 months ago (2016-08-15 18:18:41 UTC) #14

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0f40fb207d7a30ce283f18b37fb5674afb6c7580
Cr-Commit-Position: refs/heads/master@{#38639}