Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: src/isolate.cc

Issue 2246963002: [isolate] Remove unused exception handle (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: microtaskq.js Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.h ('k') | src/js/microtaskq.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 1aad57632f4d9bc2593d6df5f08578ef8085e3f4..bf0f533f5162fbca439d0d9b15f3aa00f9f3e8f9 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2990,7 +2990,11 @@ void Isolate::RunMicrotasks() {
v8::Isolate::SuppressMicrotaskExecutionScope suppress(
reinterpret_cast<v8::Isolate*>(this));
is_running_microtasks_ = true;
- RunMicrotasksInternal();
+ MaybeHandle<Object> maybe_exception;
+ MaybeHandle<Object> result = Execution::TryCall(
+ this, microtask_run(), factory()->undefined_value(), 0, NULL,
+ &maybe_exception);
+ //RunMicrotasksInternal();
is_running_microtasks_ = false;
FireMicrotasksCompletedCallback();
}
@@ -3021,7 +3025,6 @@ void Isolate::RunMicrotasksInternal() {
&maybe_exception);
handle_scope_implementer_->LeaveMicrotaskContext();
// If execution is terminating, just bail out.
- Handle<Object> exception;
if (result.is_null() && maybe_exception.is_null()) {
// Clear out any remaining callbacks in the queue.
heap()->set_microtask_queue(heap()->empty_fixed_array());
« no previous file with comments | « src/isolate.h ('k') | src/js/microtaskq.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698