Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2246863003: Swarming bots error out on bad devices. (Closed)

Created:
4 years, 4 months ago by nicholaslin
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix exceptions on logcats that can't be found. Currently when the swarming bot cannot connect to a device to get logcats, it errors out with an exception. Swarming tasks should continue to exectue with the remaining devices. Adding an if statement to check for the existence of device logcats to prevent exceptions. BUG=638051 Committed: https://crrev.com/ab7b497976d171ee4d7ceac09e994002de38407b Cr-Commit-Position: refs/heads/master@{#412152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/pylib/local/device/local_device_environment.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
nicholaslin
ptal
4 years, 4 months ago (2016-08-16 01:21:52 UTC) #4
jbudorick
lgtm
4 years, 4 months ago (2016-08-16 01:32:16 UTC) #5
jbudorick
On 2016/08/16 01:32:16, jbudorick wrote: > lgtm but your description should have a title line.
4 years, 4 months ago (2016-08-16 01:42:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246863003/1
4 years, 4 months ago (2016-08-16 02:04:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 03:07:28 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 03:10:23 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab7b497976d171ee4d7ceac09e994002de38407b
Cr-Commit-Position: refs/heads/master@{#412152}

Powered by Google App Engine
This is Rietveld 408576698