build/android/pylib/local/device/local_device_environment.py - Issue 2246863003: Swarming bots error out on bad devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_environment.py

Issue 2246863003: Swarming bots error out on bad devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/local/device/local_device_environment.py

diff --git a/build/android/pylib/local/device/local_device_environment.py b/build/android/pylib/local/device/local_device_environment.py

index 9faf0f7111f9a953919947e705b4f36b04f4d440..9f9c78745b36c321dc8ec110f112cda666d59283 100644

--- a/build/android/pylib/local/device/local_device_environment.py

+++ b/build/android/pylib/local/device/local_device_environment.py

@@ -204,7 +204,8 @@ class LocalDeviceEnvironment(environment.Environment):

if self._logcat_output_file:

file_utils.MergeFiles(

self._logcat_output_file,

- [m.output_file for m in self._logcat_monitors])

+ [m.output_file for m in self._logcat_monitors

+ if os.path.exists(m.output_file)])

shutil.rmtree(self._logcat_output_dir)

def BlacklistDevice(self, device, reason='local_device_failure'):

« no previous file with comments | « no previous file | no next file » | no next file with comments »