Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2246813002: Illustrate MakeUnique<...>(NULL, ...) issue (Closed)

Created:
4 years, 4 months ago by Adam Rice
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Illustrate MakeUnique<...>(NULL, ...) issue MakeUnique<Foo>(args) is expected to work the same as WrapUnique(new Foo(args)) except for visibility issues. In practice, it fails to compile when "args" includes NULL. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/websockets/websocket_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (5 generated)
Adam Rice
The CQ bit was checked by ricea@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-15 05:16:44 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246813002/1
4 years, 4 months ago (2016-08-15 05:16:58 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-15 05:21:48 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/207455)
4 years, 4 months ago (2016-08-15 05:21:49 UTC) #4
Adam Rice
4 years, 3 months ago (2016-08-29 07:03:02 UTC) #5
Description was changed from

==========
Illustrate MakeUnique<...>(NULL, ...) issue

MakeUnique<Foo>(args) is expected to work the same as WrapUnique(new Foo(args))
except for visibility issues. In practice, it fails to compile when "args"
includes NULL.

BUG=
==========

to

==========
Illustrate MakeUnique<...>(NULL, ...) issue

MakeUnique<Foo>(args) is expected to work the same as WrapUnique(new Foo(args))
except for visibility issues. In practice, it fails to compile when "args"
includes NULL.

BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698