Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1606)

Unified Diff: chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc

Issue 2246613003: Update cookie value and attribute setting behavior to match other UAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: iOS and unit test fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cookies/cookie_store_unittest.h » ('j') | net/cookies/cookie_store_unittest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
index d8c9decf6f073f28a31d02a25ff7fa9392df90a3..d399fd769e9f08a6d67a13f63b431849b4398f69 100644
--- a/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
@@ -286,10 +286,9 @@ TEST_F(BrowsingDataCookieHelperTest, CannedDomainCookie) {
helper->AddChangedCookie(origin, origin, "A=1; Domain=.www.google.com",
net::CookieOptions());
// Try adding invalid cookies that will be ignored.
- helper->AddChangedCookie(origin, origin, std::string(), net::CookieOptions());
- helper->AddChangedCookie(origin,
- origin,
- "C=bad guy; Domain=wrongdomain.com",
+ helper->AddChangedCookie(origin, origin, "C=not http; HttpOnly",
mmenke 2016/08/17 16:23:17 Why is this an invalid cookie? I'm not seeing why
jww 2016/08/17 16:57:08 To accept HTTP-only cookies, you have to set a spe
+ net::CookieOptions());
+ helper->AddChangedCookie(origin, origin, "C=bad guy; Domain=wrongdomain.com",
net::CookieOptions());
helper->StartFetching(
« no previous file with comments | « no previous file | net/cookies/cookie_store_unittest.h » ('j') | net/cookies/cookie_store_unittest.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698