Update cookie value and attribute setting behavior to match other UAs

chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_cookie_helper.h"
 
 #include "base/bind.h"
 #include "base/run_loop.h"
 #include "base/time/time.h"
 #include "chrome/test/base/testing_profile.h"
@@ skipping 268 matching lines @@
 
   scoped_refptr<CannedBrowsingDataCookieHelper> helper(
       new CannedBrowsingDataCookieHelper(
           testing_profile_->GetRequestContext()));
 
   ASSERT_TRUE(helper->empty());
   helper->AddChangedCookie(origin, origin, "A=1", net::CookieOptions());
   helper->AddChangedCookie(origin, origin, "A=1; Domain=.www.google.com",
                            net::CookieOptions());
   // Try adding invalid cookies that will be ignored.
-  helper->AddChangedCookie(origin, origin, std::string(), net::CookieOptions());
-  helper->AddChangedCookie(origin,
-                           origin,
-                           "C=bad guy; Domain=wrongdomain.com",
+  helper->AddChangedCookie(origin, origin, "C=not http; HttpOnly",

[mmenke, 2016/08/17 16:23:17]

Why is this an invalid cookie?  I'm not seeing why these are treated as non-HTTP
cookies.

[jww, 2016/08/17 16:57:08]

To accept HTTP-only cookies, you have to set a special net::CookieOption, which
by default is set to reject HTTP-only cookies. So in this case, we didn't set
that option (see like 285), so we expect HttpOnly cookies to be rejected.

+                           net::CookieOptions());
+  helper->AddChangedCookie(origin, origin, "C=bad guy; Domain=wrongdomain.com",
                            net::CookieOptions());
 
   helper->StartFetching(
       base::Bind(&BrowsingDataCookieHelperTest::CannedDomainCookieCallback,
                  base::Unretained(this)));
   cookie = cookie_list_;
 
   helper->Reset();
   ASSERT_TRUE(helper->empty());
 
@@ skipping 186 matching lines @@
   //   "A=1;
   //   "A=3; Domain=www.google.com"
   // Add a domain cookie and check if it increases the cookie count.
   helper->AddChangedCookie(frame2_url, frame1_url,
                            cookie_pair4 + "; Domain=" + cookie_domain,
                            net::CookieOptions());
   EXPECT_EQ(5U, helper->GetCookieCount());
 }
 
 }  // namespace