Revert "Remove performance_ui_tests from bot configs."

Revert "Remove performance_ui_tests from bot configs."

This reverts commit fc7e6f996994b76d52bda7836b631433ed9beae4,
because it broke presubmit.

BUG=

[jam, 2014-04-03 23:23:49]

what broke? It went through the CQ, shouldn't that run the tests?

I couldn't run the tests since they dont run on Windows.

If this is a trivial fix, can you fix it instead of reverting?

[iannucci, 2014-04-03 23:28:10]

On 2014/04/03 23:23:49, jam wrote:
> what broke? It went through the CQ, shouldn't that run the tests?
> 
> I couldn't run the tests since they dont run on Windows.
> 
> If this is a trivial fix, can you fix it instead of reverting?

Hm... if it ran through CQ then it SHOULD have ran all the tests. The only
caveat is that it doesn't run tests on build_internal which is tied heavily to
changes in build.

If that's the case then we should fix instead of this revert.

[iannucci, 2014-04-03 23:30:09]

On 2014/04/03 23:28:10, iannucci wrote:
> On 2014/04/03 23:23:49, jam wrote:
> > what broke? It went through the CQ, shouldn't that run the tests?
> > 
> > I couldn't run the tests since they dont run on Windows.
> > 
> > If this is a trivial fix, can you fix it instead of reverting?
> 
> Hm... if it ran through CQ then it SHOULD have ran all the tests. The only
> caveat is that it doesn't run tests on build_internal which is tied heavily to
> changes in build.
> 
> If that's the case then we should fix instead of this revert.

Unless it's super broken, then there should be a bug which captures the breakage
and we can discuss on there.

[szager, 2014-04-04 00:51:58]

https://chromereviews.googleplex.com/33207013/

On Thu, Apr 3, 2014 at 4:30 PM,  <iannucci@chromium.org> wrote:
> On 2014/04/03 23:28:10, iannucci wrote:
>>
>> On 2014/04/03 23:23:49, jam wrote:
>> > what broke? It went through the CQ, shouldn't that run the tests?
>> >
>> > I couldn't run the tests since they dont run on Windows.
>> >
>> > If this is a trivial fix, can you fix it instead of reverting?
>
>
>> Hm... if it ran through CQ then it SHOULD have ran all the tests. The only
>> caveat is that it doesn't run tests on build_internal which is tied
>> heavily to
>> changes in build.
>
>
>> If that's the case then we should fix instead of this revert.
>
>
> Unless it's super broken, then there should be a bug which captures the
> breakage
> and we can discuss on there.
>
> https://codereview.chromium.org/224653002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[luqui, 2014-04-04 01:08:19]

On 2014/04/04 00:51:58, szager wrote:
> https://chromereviews.googleplex.com/33207013/
> 
> On Thu, Apr 3, 2014 at 4:30 PM,  <mailto:iannucci@chromium.org> wrote:
> > On 2014/04/03 23:28:10, iannucci wrote:
> >>
> >> On 2014/04/03 23:23:49, jam wrote:
> >> > what broke? It went through the CQ, shouldn't that run the tests?
> >> >
> >> > I couldn't run the tests since they dont run on Windows.
> >> >
> >> > If this is a trivial fix, can you fix it instead of reverting?
> >
> >
> >> Hm... if it ran through CQ then it SHOULD have ran all the tests. The only
> >> caveat is that it doesn't run tests on build_internal which is tied
> >> heavily to
> >> changes in build.
> >
> >
> >> If that's the case then we should fix instead of this revert.
> >
> >
> > Unless it's super broken, then there should be a bug which captures the
> > breakage
> > and we can discuss on there.
> >
> > https://codereview.chromium.org/224653002/
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

szager's patch seemed to fix this before I got the revert through (I didn't know
about TBR), so I'm gonna kill this issue.

[luqui, 2014-04-04 01:09:23]

On 2014/04/04 00:51:58, szager wrote:
> https://chromereviews.googleplex.com/33207013/
> 
> On Thu, Apr 3, 2014 at 4:30 PM,  <mailto:iannucci@chromium.org> wrote:
> > On 2014/04/03 23:28:10, iannucci wrote:
> >>
> >> On 2014/04/03 23:23:49, jam wrote:
> >> > what broke? It went through the CQ, shouldn't that run the tests?
> >> >
> >> > I couldn't run the tests since they dont run on Windows.
> >> >
> >> > If this is a trivial fix, can you fix it instead of reverting?
> >
> >
> >> Hm... if it ran through CQ then it SHOULD have ran all the tests. The only
> >> caveat is that it doesn't run tests on build_internal which is tied
> >> heavily to
> >> changes in build.
> >
> >
> >> If that's the case then we should fix instead of this revert.
> >
> >
> > Unless it's super broken, then there should be a bug which captures the
> > breakage
> > and we can discuss on there.
> >
> > https://codereview.chromium.org/224653002/
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

szager's patch seemed to fix this before I got the revert through (I didn't know
about TBR), so I'm gonna kill this issue.