Enable LoginPromptBrowserTest.TestCancelAuth_OnForward

Enable LoginPromptBrowserTest.TestCancelAuth_OnForward

The test was flaky because navigation back was sometimes interrupted by
navigation to a new site before the back-navigation entry could transition from
"pending" to "committed".

The associated bug has some more details, but in the end, making sure that none
of the URLs the test navigated to returned a HTTP 404 fixed the failures.

BUG=636875
R=meacer@chromium.org

Committed: https://crrev.com/006b645010996ba6ce80fd0511a0f30b54da088e
Cr-Commit-Position: refs/heads/master@{#411752}

[vabr (Chromium), 2016-08-12 15:04:17]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 15:04:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-08-12 15:25:12]

Hi!

Could you please take a look?

Thanks,
Vaclav

[commit-bot: I haz the power, 2016-08-12 15:40:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 15:40:22]

Dry run: This issue passed the CQ dry run.

[meacer, 2016-08-12 17:23:27]

LGTM, thanks for fixing this!

https://codereview.chromium.org/2246513002/diff/1/chrome/browser/ui/login/log...
File chrome/browser/ui/login/login_handler_browsertest.cc (right):

https://codereview.chromium.org/2246513002/diff/1/chrome/browser/ui/login/log...
chrome/browser/ui/login/login_handler_browsertest.cc:108: //
(http://crbug.com/636875).
Very tiny nit: https://crbug.com :)

[vabr (Chromium), 2016-08-12 19:18:37]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 19:19:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-08-12 19:40:08]

Thank you!

Comments addressed, will send to CQ soon.

Cheers,
Vaclav

https://codereview.chromium.org/2246513002/diff/1/chrome/browser/ui/login/log...
File chrome/browser/ui/login/login_handler_browsertest.cc (right):

https://codereview.chromium.org/2246513002/diff/1/chrome/browser/ui/login/log...
chrome/browser/ui/login/login_handler_browsertest.cc:108: //
(http://crbug.com/636875).
On 2016/08/12 17:23:27, Mustafa Emre Acer wrote:
> Very tiny nit: https://crbug.com :)

Done.

[commit-bot: I haz the power, 2016-08-12 19:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 19:57:05]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-08-12 20:09:48]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-08-12 20:09:48]

The patchset sent to the CQ was uploaded after l-g-t-m from meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2246513002/#ps40001
(title: "https")

[commit-bot: I haz the power, 2016-08-12 20:10:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 20:13:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-12 20:16:02]

Description was changed from

==========
Enable LoginPromptBrowserTest.TestCancelAuth_OnForward

The test was flaky because navigation back was sometimes interrupted by
navigation to a new site before the back-navigation entry could transition from
"pending" to "committed".

The associated bug has some more details, but in the end, making sure that none
of the URLs the test navigated to returned a HTTP 404 fixed the failures.

BUG=636875
R=meacer@chromium.org
==========

to

==========
Enable LoginPromptBrowserTest.TestCancelAuth_OnForward

The test was flaky because navigation back was sometimes interrupted by
navigation to a new site before the back-navigation entry could transition from
"pending" to "committed".

The associated bug has some more details, but in the end, making sure that none
of the URLs the test navigated to returned a HTTP 404 fixed the failures.

BUG=636875
R=meacer@chromium.org

Committed: https://crrev.com/006b645010996ba6ce80fd0511a0f30b54da088e
Cr-Commit-Position: refs/heads/master@{#411752}
==========

[commit-bot: I haz the power, 2016-08-12 20:16:03]

Patchset 3 (id:??) landed as
https://crrev.com/006b645010996ba6ce80fd0511a0f30b54da088e
Cr-Commit-Position: refs/heads/master@{#411752}