Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: chrome/browser/ui/login/login_handler_browsertest.cc

Issue 2246513002: Enable LoginPromptBrowserTest.TestCancelAuth_OnForward (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@636875_split
Patch Set: https Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/login/login_handler_browsertest.cc
diff --git a/chrome/browser/ui/login/login_handler_browsertest.cc b/chrome/browser/ui/login/login_handler_browsertest.cc
index 7460dfb12274b8a14b4ebda920d5d4a094cd8951..84fe0e9cee4c5a5276196518c8b36481ea502d8d 100644
--- a/chrome/browser/ui/login/login_handler_browsertest.cc
+++ b/chrome/browser/ui/login/login_handler_browsertest.cc
@@ -103,8 +103,11 @@ const char kSingleRealmTestPage[] = "/login/single_realm.html";
const char kAuthBasicPage[] = "/auth-basic";
const char kAuthDigestPage[] = "/auth-digest";
-const char kNoAuthPage1[] = "/a";
-const char kNoAuthPage2[] = "/b";
+// It does not matter what pages are selected as no-auth, as long as they exist.
+// Navigating to non-existing pages caused flakes in the past
+// (https://crbug.com/636875).
+const char kNoAuthPage1[] = "/simple.html";
+const char kNoAuthPage2[] = "/form.html";
base::string16 ExpectedTitleFromAuth(const base::string16& username,
const base::string16& password) {
@@ -406,9 +409,7 @@ IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, TestCancelAuth_OnBack) {
}
// Test login prompt cancellation on navigation to forward.
-// TODO(crbug.com/636875) Flaky on Mac and Linux at least.
-IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest,
- DISABLED_TestCancelAuth_OnForward) {
+IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, TestCancelAuth_OnForward) {
ASSERT_TRUE(embedded_test_server()->Start());
const GURL kAuthURL = embedded_test_server()->GetURL(kAuthBasicPage);
const GURL kNoAuthURL1 = embedded_test_server()->GetURL(kNoAuthPage1);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698