Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

Issue 2246493002: Revert of Change VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/web_view_scheduler_impl_unittest.cc
diff --git a/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc b/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc
index 403df5350f87f9af755b064fc1c103834ebd7144..1c78fdab30549df0d4c18ca47d340da23aa115c3 100644
--- a/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc
+++ b/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc
@@ -34,9 +34,9 @@
clock_->Advance(base::TimeDelta::FromMicroseconds(5000));
mock_task_runner_ =
make_scoped_refptr(new cc::OrderedSimpleTaskRunner(clock_.get(), true));
- delegate_ = SchedulerTqmDelegateForTest::Create(
+ delagate_ = SchedulerTqmDelegateForTest::Create(
mock_task_runner_, base::WrapUnique(new TestTimeSource(clock_.get())));
- scheduler_.reset(new RendererSchedulerImpl(delegate_));
+ scheduler_.reset(new RendererSchedulerImpl(delagate_));
web_view_scheduler_.reset(new WebViewSchedulerImpl(
nullptr, scheduler_.get(), DisableBackgroundTimerThrottling()));
web_frame_scheduler_ =
@@ -54,7 +54,7 @@
std::unique_ptr<base::SimpleTestTickClock> clock_;
scoped_refptr<cc::OrderedSimpleTaskRunner> mock_task_runner_;
- scoped_refptr<SchedulerTqmDelegate> delegate_;
+ scoped_refptr<SchedulerTqmDelegate> delagate_;
std::unique_ptr<RendererSchedulerImpl> scheduler_;
std::unique_ptr<WebViewSchedulerImpl> web_view_scheduler_;
std::unique_ptr<WebFrameSchedulerImpl> web_frame_scheduler_;
@@ -505,9 +505,7 @@
TEST_F(WebViewSchedulerImplTest, VirtualTimePolicy_DETERMINISTIC_LOADING) {
web_view_scheduler_->setVirtualTimePolicy(
VirtualTimePolicy::DETERMINISTIC_LOADING);
- // Initially virtual time is not allowed to advance until we have seen at
- // least one load.
- EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+ EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
web_view_scheduler_->DidStartLoading(1u);
EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
@@ -525,12 +523,6 @@
EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
web_view_scheduler_->DidStopLoading(3u);
- EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
-
- web_view_scheduler_->DidStartLoading(4u);
- EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
-
- web_view_scheduler_->DidStopLoading(4u);
EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
}
@@ -560,19 +552,11 @@
TEST_F(WebViewSchedulerImplTest, BackgroundParser_DETERMINISTIC_LOADING) {
web_view_scheduler_->setVirtualTimePolicy(
VirtualTimePolicy::DETERMINISTIC_LOADING);
- // Initially virtual time is not allowed to advance until we have seen at
- // least one load.
- EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+ EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
web_view_scheduler_->IncrementBackgroundParserCount();
EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
- web_view_scheduler_->DidStartLoading(1u);
- EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
-
- web_view_scheduler_->DidStopLoading(1u);
- EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
-
web_view_scheduler_->IncrementBackgroundParserCount();
EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
@@ -581,12 +565,6 @@
web_view_scheduler_->DecrementBackgroundParserCount();
EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
-
- web_view_scheduler_->IncrementBackgroundParserCount();
- EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
-
- web_view_scheduler_->DecrementBackgroundParserCount();
- EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
}
} // namespace scheduler
« no previous file with comments | « components/scheduler/renderer/web_view_scheduler_impl.cc ('k') | third_party/WebKit/Source/platform/WebViewSchedulerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698