Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2246493002: Revert of Change VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING (Closed)

Created:
4 years, 4 months ago by kolos1
Modified:
4 years, 3 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING (patchset #6 id:100001 of https://codereview.chromium.org/2184123002/ ) Reason for revert: This CL caused failures of WebKit Android (Nexus4). See crbug.com/633321 for details. Original issue's description: > Change VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING > > Change VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING to initially > pause virtual time until at least one loading task has run. This fixes > a problem where virtual time could advance arbitrarily far before the > first fetch occurred. > > Also refactor the way virtual time is dealt with so that > RendererSchedulerImpl and ThrottlingHelper know about it and > Virtual Time is applied to all relevant queues. > > Finally remove unused WebViewSchedulerTest.cpp > > BUG=546953 > > Committed: https://crrev.com/1c815652bc24a83da99ca473d489accdeeafa435 > Cr-Commit-Position: refs/heads/master@{#408944} TBR=jochen@chromium.org,skyostil@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=546953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -240 lines) Patch
M components/scheduler/renderer/renderer_scheduler_impl.h View 6 chunks +0 lines, -12 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 10 chunks +8 lines, -59 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M components/scheduler/renderer/throttling_helper.h View 2 chunks +1 line, -6 lines 0 comments Download
M components/scheduler/renderer/throttling_helper.cc View 6 chunks +3 lines, -31 lines 0 comments Download
M components/scheduler/renderer/throttling_helper_unittest.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M components/scheduler/renderer/web_frame_scheduler_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/scheduler/renderer/web_frame_scheduler_impl.cc View 5 chunks +32 lines, -2 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl.h View 3 chunks +11 lines, -3 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl.cc View 6 chunks +24 lines, -20 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl_unittest.cc View 6 chunks +5 lines, -27 lines 0 comments Download
A third_party/WebKit/Source/platform/WebViewSchedulerTest.cpp View 1 chunk +83 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp View 5 chunks +8 lines, -21 lines 0 comments Download
M third_party/WebKit/public/platform/WebViewScheduler.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
kolos1
Created Revert of Change VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING
4 years, 4 months ago (2016-08-12 12:51:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246493002/1
4 years, 4 months ago (2016-08-12 12:51:46 UTC) #3
alex clarke (OOO till 29th)
4 years, 4 months ago (2016-08-22 15:38:44 UTC) #9
Removing myself from the R line :)  I guess we can probably close this now.

Powered by Google App Engine
This is Rietveld 408576698