Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: src/utils/SkShadowPaintFilterCanvas.cpp

Issue 2246463004: Added distance attenuation and diffuse shading to PointLights (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: made req changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/core/SkShadowShader.cpp ('K') | « src/core/SkShadowShader.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/utils/SkShadowPaintFilterCanvas.cpp
diff --git a/src/utils/SkShadowPaintFilterCanvas.cpp b/src/utils/SkShadowPaintFilterCanvas.cpp
index 31b7661296151023a8266cf67d5d74468b181dc5..0198eb4026e547509553f8cffbabb5398e1832ea 100644
--- a/src/utils/SkShadowPaintFilterCanvas.cpp
+++ b/src/utils/SkShadowPaintFilterCanvas.cpp
@@ -35,6 +35,10 @@ bool SkShadowPaintFilterCanvas::onFilter(SkTCopyOnFirstWrite<SkPaint>* paint, Ty
SkISize SkShadowPaintFilterCanvas::ComputeDepthMapSize(const SkLights::Light& light, int maxDepth,
int width, int height) {
SkASSERT(light.type() != SkLights::Light::kAmbient_LightType);
+ if (light.type() != SkLights::Light::kDirectional_LightType) {
+ return SkISize::Make(width *2 , height * 2);
+ }
+
int dMapWidth = SkMin32(maxDepth * fabs(light.dir().fX) + width,
width * 2);
int dMapHeight = SkMin32(maxDepth * fabs(light.dir().fY) + height,
@@ -56,7 +60,7 @@ void SkShadowPaintFilterCanvas::updateMatrix() {
// It is up to the user to set the 0th light in fLights to
// the light the want to render the depth map with.
- if (this->fLights->light(0).type() != SkLights::Light::kAmbient_LightType) {
+ if (this->fLights->light(0).type() == SkLights::Light::kDirectional_LightType) {
const SkVector3& lightDir = this->fLights->light(0).dir();
SkScalar x = lightDir.fX * this->getZ();
SkScalar y = lightDir.fY * this->getZ();
« src/core/SkShadowShader.cpp ('K') | « src/core/SkShadowShader.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698