Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Issue 2246463002: [compiler] Remove compiler internals from CodeAssembler. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove compiler internals from CodeAssembler. This removes some compiler internals as well as some JavaScript specific helper from the CodeAssembler, by either hiding or moving the support into the CodeStubAssembler. R=bmeurer@chromium.org Committed: https://crrev.com/68868c73c4d1a583c80876bafd659d6a88b74487 Cr-Commit-Position: refs/heads/master@{#38617}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -38 lines) Patch
M src/builtins/builtins-internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stub-assembler.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-assembler.h View 4 chunks +0 lines, -18 lines 0 comments Download
M src/compiler/code-assembler.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M test/cctest/compiler/code-assembler-tester.h View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-code-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.h View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-12 11:42:28 UTC) #3
Benedikt Meurer
Awesome. Ship it. LGTM.
4 years, 4 months ago (2016-08-12 11:43:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246463002/1
4 years, 4 months ago (2016-08-12 12:55:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 12:57:39 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 12:57:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68868c73c4d1a583c80876bafd659d6a88b74487
Cr-Commit-Position: refs/heads/master@{#38617}

Powered by Google App Engine
This is Rietveld 408576698