Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2241783002: [interpreter] Compiler shortcut when bytecode present. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-code-assembler
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Compiler shortcut when bytecode present. This adds a shortcut to the compilation pipeline that makes sure we are not regenerating bytecode when it has been preserved from a previous request. This can happen when code flushing removes baseline code, thereby clearing the entry trampoline but leaving bytecode intact. R=yangguo@chromium.org BUG=v8:5265 Committed: https://crrev.com/a7c63607d2bfbc7234af036198fac320e664a977 Cr-Commit-Position: refs/heads/master@{#38620}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/compiler.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-12 12:53:51 UTC) #2
Yang
lgtm
4 years, 4 months ago (2016-08-12 13:39:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241783002/20001
4 years, 4 months ago (2016-08-12 13:43:07 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 13:44:48 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 13:45:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7c63607d2bfbc7234af036198fac320e664a977
Cr-Commit-Position: refs/heads/master@{#38620}

Powered by Google App Engine
This is Rietveld 408576698