Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2246373003: Fix the PDF download button. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Charlie Reis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the PDF download button. r411848 did not update the message receiving from RVH to RFH, even though the sender changed from RV to RF. BUG=638087 Committed: https://crrev.com/e6c1ffdccf7a7244e4b035532147757e80f1bd66 Cr-Commit-Position: refs/heads/master@{#412251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M components/pdf/browser/pdf_web_contents_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.cc View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
Lei Zhang
avi: Please review since creis is OOO. I'm working on a PDFExtensionTest but it's hitting ...
4 years, 4 months ago (2016-08-16 15:07:50 UTC) #8
Avi (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-16 15:29:34 UTC) #9
Lei Zhang
Thanks. The test is here: https://codereview.chromium.org/2252573003 Maybe my workstation is just being wonky and the ...
4 years, 4 months ago (2016-08-16 15:37:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2246373003/1
4 years, 4 months ago (2016-08-16 15:38:33 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 15:42:16 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 15:44:31 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6c1ffdccf7a7244e4b035532147757e80f1bd66
Cr-Commit-Position: refs/heads/master@{#412251}

Powered by Google App Engine
This is Rietveld 408576698